On Sat, Jun 18, 2016 at 09:15:41PM +0200, Roberto S. Galende wrote: > I am looking for a sponsor for my package "bytes-circle" > > Package name : bytes-circle > Version : 2.2-2
Hi! Looks almost good, I found just three minor issues. None of them is a show-stopper, but let's have the package in a better shape from the start. debian/changelog: * why the Debian revision is -2 rather than -1? That's appropriate only of there's a -1 in the changelog. And that would make sense only if the packaging had a meaningful history in the wild (like, import from a derivative or a public repository). debian/control: * please say what the program is for (ie, the first and last paragraphs) rather than describing its use and output. That's what the man page and/or README are for. debian/rules: * please move flags exports before including dpkg/default.mk. The order matters -- your version doesn't use hardening. Also, I wonder if there's a better place for the URL than /usr/share/doc/README. Other stuff in that file are build instructions which are irrelevant for packaged software. BTW, ♥ the "circulos meos" reference. Meow! -- An imaginary friend squared is a real enemy.
