Petter Reinholdtsen <p...@hungry.com> writes:

> Note, this shell script is a replacement for the original C version.  I
> suggested its inclusion in <URL:http://bugs.debian.org/660216 > but
> later concluded that it was better to try to get the function into an
> existing package instead of creating a deb with only one binary for such
> small task.  And then the shell wrapper came around because it removed
> the need to compile something to get cron jobs working.

Ahh, right.  Though as I think you mentioned the C version doesn't use
liblockfile, which we'd want, and as the code mentions, it probably
needs fork/exec, and I'd want signal handling, etc.

So I don't know if/when I might hack on this any further, but if I do,
it may a bit.


I'd also thought about suggesting that the existing shell script might
want to run the subcommand via something like

  "$@"

instead of

  sh -c "$COMMAND"

but then realized that maybe the intention was for the (single) command
string to be parsed by sh. i.e.

  run-with-lockfile somelock "apache -d \"some dir\" -f \"some file.conf\""

and not anything like

  run-with-lockfile somelock apache -d "some dir" -f "some file.conf"

Thanks
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

Reply via email to