Package: binutils
Version: 2.16.1cvs20051214-1
Severity: important
Tags: patch
Hi,
binutils fails to build on hurd-i386 since bfd got switched to using
-Werror by default:
Automatic build of binutils_2.16.1cvs20051214-1 on beethoven by
sbuild/hurd-i386 79
Build started at 20060116-1339
******************************************************************************
[...]
Checking correctness of source dependencies...
Toolchain package versions: libc0.3-dev_2.3.5-6 gcc-4.0_4.0.2-4
g++-4.0_4.0.2-4 binutils_2.16.1-2 libstdc++6-4.0-dev_4.0.2-4 libstdc++6_4.0.2-4
------------------------------------------------------------------------------
dpkg-source: extracting binutils in binutils-2.16.1cvs20051214
dpkg-source: unpacking binutils_2.16.1cvs20051214.orig.tar.gz
dpkg-source: applying
/org/buildd/build/binutils_2.16.1cvs20051214-1.diff.gz
dpkg-buildpackage: source package is binutils
dpkg-buildpackage: source version is 2.16.1cvs20051214-1
dpkg-buildpackage: host architecture hurd-i386
[...]
gcc -DHAVE_CONFIG_H -I. -I../../bfd -I. -I. -I../../bfd
-I../../bfd/../include -I../../bfd/../intl -I../intl -W -Wall
-Wstrict-prototypes -Wmissing-prototypes -Werror -g -O2 -c
../../bfd/elf.c -fPIC -DPIC -o .libs/elf.o
cc1: warnings being treated as errors
../../bfd/elf.c: In function 'elfcore_write_pstatus':
../../bfd/elf.c:7895: warning: unused parameter 'cursig'
../../bfd/elf.c:7896: warning: unused parameter 'gregs'
make[5]: *** [elf.lo] Error 1
make[5]: Leaving directory
`/build/buildd/binutils-2.16.1cvs20051214/builddir-single/bfd'
The full build log can be found here:
http://experimental.ftbfs.de/fetch.php?&pkg=binutils&ver=2.16.1cvs20051214-1&arch=hurd-i386&stamp=1137416618&file=log&as=raw
This has been fixed upstream as #2159 with the following ChangeLog:
2006-01-17 Nick Clifton <[EMAIL PROTECTED]>
PR binutils/2159
* elf.c (elfcore_write_pstatus): Add ATTRIBUTE_UNUSED to unused
parameters.
I have attached a corresponding dpatch should you decide to upload
another Debian revision before the next snapshot.
cheers,
Michael
#!/bin/sh -e
## fix_hurd_bfd_warning.dpatch
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Description: fix warning in GNU/Hurd specific code path in bfd
## DP: Author: Nick Clifton <[EMAIL PROTECTED]>
## DP: Upstream status: Applied to CVS HEAD
## DP: Date: 2006/01/17
if [ $# -ne 1 ]; then
echo >&2 "`basename $0`: script expects -patch|-unpatch as argument"
exit 1
fi
[ -f debian/patches/00patch-opts ] && . debian/patches/00patch-opts
patch_opts="${patch_opts:--f --no-backup-if-mismatch}"
case "$1" in
-patch) patch $patch_opts -p1 < $0;;
-unpatch) patch $patch_opts -p1 -R < $0;;
*)
echo >&2 "`basename $0`: script expects -patch|-unpatch as
argument"
exit 1;;
esac
exit 0
@DPATCH@
2006-01-17 Nick Clifton <[EMAIL PROTECTED]>
PR binutils/2159
* elf.c (elfcore_write_pstatus): Add ATTRIBUTE_UNUSED to unused
parameters.
===================================================================
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.323
retrieving revision 1.324
diff -u -r1.323 -r1.324
--- src/bfd/elf.c 2005/12/27 09:22:59 1.323
+++ src/bfd/elf.c 2006/01/17 10:34:43 1.324
@@ -7889,8 +7889,8 @@
char *buf,
int *bufsiz,
long pid,
- int cursig,
- const void *gregs)
+ int cursig ATTRIBUTE_UNUSED,
+ const void *gregs ATTRIBUTE_UNUSED)
{
pstatus_t pstat;
char *note_name = "CORE";
