Control: tags -1 - patch Hi!
On Sun, 2016-06-05 at 14:37:51 -0700, Josh Triplett wrote: > Control: tags -1 + patch > > The attached patch implements the change I suggested, dropping fcntl > locking in favor of flock, and documenting that change in the changelog > along with the rationale. > >From 0c6eddc8200e7bea482ad65c5870f7977847d26a Mon Sep 17 00:00:00 2001 > From: Josh Triplett <j...@joshtriplett.org> > Date: Sun, 5 Jun 2016 14:27:38 -0700 > Subject: [PATCH] Always use flock for file locking; drop Recommends on > libfile-fcntllock-perl > > Per the flock(2) manpage, NFS clients going back to Linux 2.6.12 > translate flock into an fcntl lock on the entire file. This is a non-portable Linux-only assumption. dpkg works on other systems besides Linux-based ones. I'm also unhappy even about the fallback to flock when fcntl is not available, as on other systems the locks might not see each other so that's the worst possible behavior. I've in fact been looking into this recently. And I'll ping the perl maintainers to try to get the required packaging fixes implemented in libfile-fcntllock-file done. Otherwise I'll probably embed something similar to that module as a private Dpkg module. Thanks, Guillem
