Control: tag -1 + patch confirmed On Thu, 26 May 2016 23:23:46 +0300, Niko Tyni wrote:
> Package: blhc > Version: 0.05-0.1 > Severity: important > User: debian-p...@lists.debian.org > Usertags: perl-5.24-transition > > This package fails to build from source with Perl 5.24 (currently in > experimental.) It looks like Pod::Usage output formatting has > changed, causing test failures. > > # Failed test ' --invalid (output)' > # at t/tests.t line 45. > # got: 'Unknown option: invalid > # Usage: > # blhc [options] <dpkg-buildpackage build log file>.. > # > # ' > # expected: 'Unknown option: invalid > # Usage: > # blhc [*options*] *<dpkg-buildpackage build log file>..* > # > # ' > [...] > Test Summary Report > ------------------- > t/tests.t (Wstat: 2304 Tests: 218 Failed: 9) > Failed tests: 2, 4, 8, 22, 24, 26, 46, 48, 50 > Non-zero exit status: 9 > Files=1, Tests=218, 11 wallclock secs ( 0.09 usr 0.03 sys + 8.86 cusr > 1.41 csys = 10.39 CPU) > Result: FAIL Yup, Pod::Usage changed its output in 1.65: https://metacpan.org/diff/file?target=MAREKR%2FPod-Usage-1.65%2F&source=MAREKR%2FPod-Usage-1.64%2F#lib/Pod/Usage.pm Attached is a (rather ugly) patch that works with (Pod::Usage in) perl 5.22 and 5.24. Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Rolling Stones
Description: Pod::Usage changed its output in 1.65: https://metacpan.org/diff/file?target=MAREKR%2FPod-Usage-1.65%2F&source=MAREKR%2FPod-Usage-1.64%2F#lib/Pod/Usage.pm Update t/tests.t to handle both versions. Origin: vendor Bug-Debian: https://bugs.debian.org/825428 Forwarded: no Author: gregor herrmann <gre...@debian.org> Last-Update: 2016-06-05 --- a/t/tests.t +++ b/t/tests.t @@ -48,11 +48,17 @@ # Usage, invalid arguments. -my $usage = +use Pod::Usage; +my $usage = ( $Pod::Usage::VERSION < 1.65 ? 'Usage: blhc [*options*] *<dpkg-buildpackage build log file>..* -'; +' + : + 'Usage: + blhc [options] <dpkg-buildpackage build log file>.. + +'); is_blhc '', '--invalid', 2, "Unknown option: invalid\n" . $usage; @@ -79,7 +85,7 @@ is_blhc '', '--help', 1, qr/^Usage: - blhc \[\*options\*\] \*<dpkg-buildpackage build log file>\.\.\* + blhc \[\*?options\*?\] \*?<dpkg-buildpackage build log file>\.\.\*? Options: /s; @@ -118,23 +124,14 @@ # Invalid option. is_blhc 'ignore-flag', '--ignore-arch-flag -g', 2, - 'Value "-g" invalid for option ignore-arch-flag ("arch:flag" expected) -Usage: - blhc [*options*] *<dpkg-buildpackage build log file>..* - -'; + 'Value "-g" invalid for option ignore-arch-flag ("arch:flag" expected)' + . "\n$usage"; is_blhc 'ignore-flag', '--ignore-arch-flag -g:', 2, - 'Value "-g:" invalid for option ignore-arch-flag ("arch:flag" expected) -Usage: - blhc [*options*] *<dpkg-buildpackage build log file>..* - -'; + 'Value "-g:" invalid for option ignore-arch-flag ("arch:flag" expected)' + . "\n$usage"; is_blhc 'ignore-flag', '--ignore-arch-flag :amd64', 2, - 'Value ":amd64" invalid for option ignore-arch-flag ("arch:flag" expected) -Usage: - blhc [*options*] *<dpkg-buildpackage build log file>..* - -'; + 'Value ":amd64" invalid for option ignore-arch-flag ("arch:flag" expected)' + . "\n$usage"; # Wrong architecture. is_blhc 'ignore-flag', '--ignore-arch-flag amd64:-g', 8, @@ -181,23 +178,14 @@ # Invalid option. is_blhc 'ignore-line', '--ignore-arch-line .+', 2, - 'Value ".+" invalid for option ignore-arch-line ("arch:line" expected) -Usage: - blhc [*options*] *<dpkg-buildpackage build log file>..* - -'; + 'Value ".+" invalid for option ignore-arch-line ("arch:line" expected)' + . "\n$usage"; is_blhc 'ignore-line', '--ignore-arch-line .+:', 2, - 'Value ".+:" invalid for option ignore-arch-line ("arch:line" expected) -Usage: - blhc [*options*] *<dpkg-buildpackage build log file>..* - -'; + 'Value ".+:" invalid for option ignore-arch-line ("arch:line" expected)' + . "\n$usage"; is_blhc 'ignore-line', '--ignore-arch-line :amd64', 2, - 'Value ":amd64" invalid for option ignore-arch-line ("arch:line" expected) -Usage: - blhc [*options*] *<dpkg-buildpackage build log file>..* - -'; + 'Value ":amd64" invalid for option ignore-arch-line ("arch:line" expected)' + . "\n$usage"; # Wrong architecture. is_blhc 'ignore-line', '--ignore-arch-line "amd64:.+"', 8,
signature.asc
Description: Digital Signature
