Hi Sebastian, sorry for the huge delay. On 28/04/16 01:59, Sebastian Parschauer wrote: > On 25.04.2016 17:58, Emilio Pozuelo Monfort wrote: >>> My plan is to become the new Debian scanmem package maintainer and to >>> provide latest versions myself. >>> >>> I already started with a packaging repo at: >>> https://github.com/sriemer/scanmem-debian >>> >>> I need supporters for this plan. Updating is the better choice IMHO. >>> >>> Can I count on your support? >>> >>> If yes, then I'll prepare the new package and send it to you for review. >> >> Yes, please send me a link to a .dsc when ready and I'll have a look. > > Hi Emilio, > > I'm ready. I've released and picked upstream version v0.15.7 as it > contains quite important security fixes found by Coverity and a security > researcher. So we'll jump from 0.13-1 to 0.15.7-1. > > I've prepared the new Debian packaging commits here: > > https://github.com/sriemer/scanmem-debian/commits/master > > Then I've gathered and extracted the upstream tarball and run > 'debuild -S' to provide the .dsc file to you: > > https://github.com/sriemer/scanmem-debian/tree/source > > I've built this for "testing" and "unstable" for i386 and amd64 in local > sbuild environments in the branches "unstable-amd64", "unstable-i386", > "testing-amd64" and "testing-i386". > > Lintian is only still warning about the fact that libscanmem is not > provided in a separate package. It is only there for better backend > communication for GameConqueror. So this can be ignored.
Hmm. If that's the case, you shouldn't install the libscanmem.so symlink. I see you use it for dlopening the lib in gameconqueror, but that could happen by dlopening libscanmem.so.1. Also, it would be better if the library was installed into a /usr/lib/scanmem/ directory (or similar) so it wasn't on the default library search path. Though I don't think that's strictly necessary. gameconqueror depends on scanmem (>= 0.15.7). What prevents scanmem from being upgraded to, say, 0.16, where libscanmem has changed incompatibly, while gameconqueror stays at 0.15.7? You should probably add a strict versioning. Other than that things look good. > I've tested scanmem and GC in fresh Debian "testing" VMs for amd64 and > i386 with GNOME and MATE for now. All the upstream test cases have been > passed. The packages are working like a charm and as expected. :-) No > files are missing in the .deb packages and the GC icon is visible right > away after installation. :-) Good. > This is done. Please use the "source" branch, build the packages from > there and upload the new version. I'll upload as soon as those comments are addressed. Cheers, Emilio
