Jose Gutierrez de la Concha: > Hi Ondřej, > > I have been looking over the patches included in ice3.5 package, I think > most of the patches are not longer required with 3.6, see comments below
[...] > add-dpkg-buildflags > > is this really required? we build packages with dh and the flags are > being set without need to patch the 3.6 build system. This patch is for adding Hardening flags, and was required because hardening-wrapper didn't work with GCC 5 and zeroc-ice depended on it, causing a bug whereby zeroc-ice was removed from Testing. More info on Hardening here: https://wiki.debian.org/Hardening Using 'dh' in debian/rules does not automatically harden in many cases because it's common for Makefiles to hard-set build flags past what dh sets; for instance this line that the patch changes from zeroc-ice 3.5.1: CPPFLAGS = literally removes any CPPFLAGS that 'dh' would have set. The best way I know of to test the hardening flags is to use 'blhc' on the log of the build (in the 'blhc' package) -- the best result is no warning output. Try running blhc on your zeroc-ice 3.6 build logs. > hurd-fixes > > We haven't tested hurd at this point I looked through the list of archived bugs for zeroc-ice and couldn't find what this patch is related to. (Too bad this patch didn't have DEP3 headers.) Hurd isn't an official release architecture for Debian, so "it's good if it can be made to work where feasible". [...] > Let me know your thoughts on this One other thing I should mention for clarity is that Debian *Sid* is the target distribution -- because all uploads to go Sid. *If* no serious bugs get reported then the package automatically transitions to Testing (currently named "Stretch") in about 5 days (assuming "urgency=medium" is used in the changelog entry, which is the default). So right now Stretch generally follows Sid with a 5-day delay, but that will drastically change when the freeze comes in November. -- Chris -- Chris Knadle chris.kna...@coredump.us
