On 2016-05-21, Ricardo Salveti wrote:
> u-boot 2016.05 already includes support for Dragonboard410c (96boards
> CE compatible), just missing packaging support. Please see the
> attached patch for the required changes to make it supported.

Thanks!


> The patch also includes a packaging patch that fixes the distro
> bootcmd support, and also some minor fixes for extlinux and pxeboot
> support (which I'm also forwarding upstream).

Please get those patches upstream. Though at a quick glance, the changes
seem mostly reasonable. A few comments below...


> diff --git a/debian/control b/debian/control
> index 6da1a69..68b4d3b 100644
> --- a/debian/control
> +++ b/debian/control
> @@ -10,7 +10,7 @@ Vcs-Git: 
> https://anonscm.debian.org/git/collab-maint/u-boot.git
>  Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/u-boot.git/
>  
>  Package: u-boot
> -Architecture: armel armhf avr32 mips sh4
> +Architecture: armel armhf arm64 avr32 mips sh4
>  Multi-Arch: same
>  Depends: ${misc:Depends},
>   u-boot-imx [armhf], u-boot-omap [armhf], u-boot-sunxi [armhf], 
> u-boot-exynos [armhf]

As Martin mentioned, we should probably split this into a separate
package, such as u-boot-qcom.


> +diff --git a/include/configs/dragonboard410c.h 
> b/include/configs/dragonboard410c.h
> +index d32889d..d584c3d 100644
> +--- a/include/configs/dragonboard410c.h
> ++++ b/include/configs/dragonboard410c.h
...
> +@@ -126,10 +126,13 @@ REFLASH(dragonboard/u-boot.img, 8)\
> +     "fdtfile=apq8016-sbc.dtb\0" \
> +     "fdt_addr_r=0x83000000\0"\
> +     "ramdisk_addr_r=0x84000000\0"\
> +-    BOOTENV
> ++    "scriptaddr=0x90000000\0"\
> ++    "pxefile_addr_r=0x91000000\0"\
> ++    BOOTENV \
> ++    "bootcmd_mmc0=setenv devnum 0; setenv distro_bootpart a; run mmc_boot\0"

Redefining bootcmd_mmc0 might not fly well with upstream. I'm guessing
you've added this because distro_bootcmd doesn't support the partition
layout for the drangonboard 410c?


> + #define CONFIG_ENV_IS_NOWHERE
> +-#define CONFIG_ENV_SIZE                     0x1000
> ++#define CONFIG_ENV_SIZE                     0x2000
> + #define CONFIG_ENV_VARS_UBOOT_CONFIG
> + #define CONFIG_SYS_NO_FLASH

Is there any chance that 0x2000 might extend beyond the partition
boundary or whatever location the ENV is stored in?


live well,
  vagrant

Attachment: signature.asc
Description: PGP signature

Reply via email to