Control: forwarded -1 https://sourceforge.net/p/smplayer/bugs/747/
Control: tags -1 + fixed-upstream patch

On 2016-05-25 18:34 +0200, Sven Joachim wrote:

> Package: smplayer
> Version: 16.4.0~ds0-1
>
> Opening a directory (Open -> Directory... -> Choose) to play all files
> in it takes a very long time (depending on the number and the size of
> the files of files in it, but a CD rip just took several minutes),
> during which smplayer is unresponsive and appears to be hung.

This had not been the case in previous versions.  For some reason, under
Preferences -> Playlist the option "Get info automatically about files
added (slow)" was checked.  Disabling that option fixed the problem.

> It seems to me the problem is that smplayer passes "-frames 1" to
> mplayer which does not work as intended for audio files.  Perhaps it
> should use "-frames 0" instead?

Turns out exactly that has been suggested upstream already, and was
implemented in SVN revision 7729. :-) I'm attaching the diff for that
revision.

Cheers,
       Sven

Index: infoprovider.cpp
===================================================================
--- infoprovider.cpp	(revision 7728)
+++ infoprovider.cpp	(revision 7729)
@@ -35,7 +35,9 @@
 
 	proc->setExecutable(mplayer_bin);
 	proc->setFixedOptions();
-	proc->setOption("frames", "1");
+	QString nframes = "1";
+	if (proc->isMPlayer()) nframes = "0";
+	proc->setOption("frames", nframes);
 	proc->setOption("vo", "null");
 	proc->setOption("ao", "null");
 	#ifdef Q_OS_WIN

Reply via email to