There's a new release in the git repo:
https://git.sur5r.net/tio/
* Jakub Wilk <jw...@debian.org>, 2016-05-07, 14:44:
Please run autoreconf at build time. (That should be a matter of
replacing the "autotools-dev" addon with "autoreconf".)
This is now fixed, but now-unused autotools-dev is still in
Build-Depends.
My git doesn't like the certificate:
fatal: unable to access 'https://git.sur5r.net/tio/': server certificate
verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
On IRC I was told this is intentional. Note to self: to disable
certificate validation, pass "-c http.sslVerify=false" to git.
Our infrastructure doesn't support watch files in version 4 yet, so
please downgrade it to 3.
Please do s/http/https/ in the Homepage field.
The package synopsis should start with a lowercase letter; see DevRef
ยง6.2.2.
"Forwarded: not-needed" should be "Forwarded: yes", shouldn't it?
I'd rather have only a single changelog entry for the initial release.
export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
This seem unnecessary, given that this program doesn't link to any
libraries (except implicitly to libc).
Now some nitpicking about upstream code (to be fixed at your (or
upstream's) leisure):
printf("License GPLv2: GNU GPL version 2 or later
<http://gnu.org/licenses/gpl-2.0.html>.\n");
I'd do s/v2/v2+/.
Or maybe less repetitively: s/ GPLv2:/:/.
option.baudrate = baudrate = atoi(optarg);
atoi() doesn't do any error checking. (In fact, POSIX says that "if the
value cannot be represented, the behavior is undefined".) I'd recommend
using strtol() instead.
--
Jakub Wilk
