Control: block -1 by 795841 Control: block 788539 by 795841 On Wed, 2016-05-18 at 21:12 +0000, Gianfranco Costamagna wrote: > Hi Lumin, > > >Thank you James, I've solved this problem. > I don't want to do the final checks until Ghislain gives me his personal ack, > but > I see that the python3 dependencies might be fixed with not-much effort. > > issues I would like to see fixed or answered: > python/requirements.txt <-- please check for missing runtime dependencies.
debhelper will pick them up as python package dependencies: dh_python2 --requires=python/requirements.txt > why some of them are outside that shlibs:Depends and not picked up > automatically? > talking about > python-skimage and python-protobuf I don't remember why I put python-skimage there but I remember that python-protobuf was put there as explicit remind for me, indicating that protobuf is the blocker of python3-caffe-*. > e.g. you can't run cython if you don't put it on build-dependencies. > also all the requiremends, need to be in build-dependencies in order to be > picked up > by python:Depends correctly. Python modules listed in requirements are not required at runtime, except for numpy and boost-python. I noticed that dh_python2 complains about "unused python:Depends" but the resulting python package dependency is correct: > Depends: libcaffe-cpu1 (= 1.0.0~rc3-1), python-skimage, python-protobuf, > cython, ipython, python (<< 2.8), python (>= 2.7~), python -dateutil, > python-gflags, python-h5py, python-leveldb, python-matplotlib, > python-networkx, python-nose, python-numpy (>= 1:1.8.0), > python-numpy-abi9, python-pandas, python-pil, python-scipy, python-six, > python-yaml, python:any (>= 2.7.5-5~), libboost-python1.55. 0, > libboost-system1.55.0, libc6 (>= 2.4), libgcc1 (>= 1:4.1.1), libgoogle-glog0, > libprotobuf9, libpython2.7 (>= 2.7), libstdc++6 (> = 4.2.1) Why should runtime deps be added into build-dep, which are useless unless I provide python-caffe-* testsuite. > for the python3 porting: > protobuf is python3 ready > > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=795841 > what about helping the maintainer in uploading it? Really ready? I looked into the packaging repo, both master and package-3.x branch and I see no python3-protobuf package listed there. http://anonscm.debian.org/cgit/pkg-protobuf/pkg-protobuf.git/tree/debian/control?h=master http://anonscm.debian.org/cgit/pkg-protobuf/pkg-protobuf.git/tree/debian/control?h=packaging-3.x The caffe package was ever blocked by * the GCC-4 -> GCC-5 transition and dependency library ABI bump * CUDA 6.5 -> 7.0 bump * CUDA 7.0 -> 7.5 bump and now it is blocked by * python3-protobuf if python3 is really required. > for skimage: > the package has two RC bugs, both fixed upstream > #788965, #794859. > you need to fix all the dependencies if you really want your package in > Stretch! > (btw for skimage, the new release fixes all the RC bugs > I also asked why it hasn't been packaged yet > https://github.com/scikit-image/scikit-image/issues/2091 > ) It seems that skimage is not a blocker of Caffe. $ apt list python3-skimage* -a Listing... Done python3-skimage/stable,unstable,now 0.10.1-2 all [installed]