Cc:ing bug > From: Loïc Minier <loic.min...@dooz.org <mailto:loic.min...@dooz.org>> > Subject: Re : Problem with debian vlan package > Date: 16 mai 2016 22:20:25 UTC+2 > To: Ryan Castellucci <ryan.castellu...@gmail.com > <mailto:ryan.castellu...@gmail.com>> > Cc: Ard van Breemen <a...@kwaak.net <mailto:a...@kwaak.net>>, l...@debian.org > <mailto:l...@debian.org> > > Hi folks, > > And sorry for the delay, was travelling for work last week. (I’m back to my > regular TZ but still jet lagged :-) > > NB: This is an old bug (2007) and the patch in git and revert themselves are > old (2010), so I might not recollect this correctly. > > IIRC, multiple non-trivial changes were landed in git by Arnd, and I couldn’t > easily make sense of all of them. I had to prepare an upload for whatever > reason and I reverted them in git: > http://anonscm.debian.org/cgit/collab-maint/vlan.git/commit/?id=3eed5b7482eb7952425b7455445df22419346047 > > <http://anonscm.debian.org/cgit/collab-maint/vlan.git/commit/?id=3eed5b7482eb7952425b7455445df22419346047> > Thinking it would be easy to fish them out of Git for future uploads. > > If you’d like me to reconsider the whole changes or just the minimal diff for > this bug, I’d be happy to reconsider them one by one; I can’t reapply the > whole revert though, it’s too much for me to review in one go. > > Ideally, we should have some tests along the package to make sure we don’t > introduce any regression. > > Cheers, > - Loïc > >> Le 16 mai 2016 à 21:47, Ryan Castellucci <ryan.castellu...@gmail.com >> <mailto:ryan.castellu...@gmail.com>> a écrit : >> >> Loïc, >> >> What do we need to do to get the fix merged? >> >> On Fri, May 6, 2016 at 1:57 PM, Ryan Castellucci <ryan.castellu...@gmail.com >> <mailto:ryan.castellu...@gmail.com>> wrote: >> Looks like Loïc Minier did the revert. >> >> Loïc, what's the deal here? >> >> Thanks, >> Ryan >> >> On Fri, May 6, 2016 at 2:59 PM, Ard van Breemen <a...@kwaak.net >> <mailto:a...@kwaak.net>> wrote: >> Hi, >> >> Ryan Castellucci schreef op 2016-05-05 22:36: >> Hello, >> >> Could you please respond to this bug? >> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=452049 >> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=452049> >> >> The fix provided is trivial and has no downside that I can see to >> accept. >> >> I've fixed that: >> http://anonscm.debian.org/cgit/collab-maint/vlan.git/commit/?id=6372a3daa44852730762385860327581c0dd67fa >> >> <http://anonscm.debian.org/cgit/collab-maint/vlan.git/commit/?id=6372a3daa44852730762385860327581c0dd67fa> >> and: >> http://anonscm.debian.org/cgit/collab-maint/vlan.git/commit/?id=9e87ff83ca1f80987e98b11eabb9b2408fc47cd0 >> >> <http://anonscm.debian.org/cgit/collab-maint/vlan.git/commit/?id=9e87ff83ca1f80987e98b11eabb9b2408fc47cd0> >> >> My fixes got reverted, so I don't know what I can do about it. >> http://anonscm.debian.org/cgit/collab-maint/vlan.git/tree/?id=cd8950c1dbc21200c5d61fa42fa3ed1f9188dae5 >> >> <http://anonscm.debian.org/cgit/collab-maint/vlan.git/tree/?id=cd8950c1dbc21200c5d61fa42fa3ed1f9188dae5> >> is my last official release that hit my own cloud (300+ servers) before it >> got reverted, and I haven't regained control since. >> >> Regards, >> Ard van Breemen >> >> >> >> -- >> Ryan Castellucci https://rya.nc/ <https://rya.nc/> >> >> >> -- >> Ryan Castellucci https://rya.nc/ <https://rya.nc/>
