Thanks for the review. I'm glad you liked it! > 1) why an empty dh_[auto_]install override?
dh_auto_install does not do anything useful here: `make install` for some reason does not actually install anything but just compiles some examples (that won't be part of the Debian package) and then finishes with the note "No install provided, see comments in the README" The README basically says that the installation should be performed manually by copying the desired files to the desired directories, which is what dh_install will do in the next step. Therefore, calling dh_auto_install probably won't hurt, but it does waste time, which is why I have overwritten it with an empty rule. > 2) why exporting fPIC manually? The hardening rules do export -fPIE, but not -fPIC. Without -fPIC, I get the following error when trying to link the static library into another shared library: /usr/bin/ld: /tmp/[...]/usr/lib/libdwarf.a(dwarf_alloc.o): relocation R_X86_64_PC32 against symbol `dwarf_dealloc' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: Bad value collect2: error: ld returned 1 exit status Your patch doesn't fix that, either (although I might have missed something there; I'm not exactly fluent in Autotools), whereas if I'm building libdwarf with -fPIC, the shared library builds and links just fine. Thanks again, Fabian
