On 05/12/2016 10:58 PM, Aaron M. Ucko wrote: > Sebastiaan Couwenberg writes: > >> https://quickgit.kde.org/?p=kpty.git&a=commitdiff&h=35ea45b588db9afcbd796576833ac338c6b4b8e8 >> >> Is this your suggested patch? And if so, can you test it on kfreebsd-*? > > That's a fair question. > > The code change works if I hardcode -DHAVE_TCGETATTR -DHAVE_TCSETATTR on > line 13 of src/plugins/grass/CMakeLists.txt. I initially tried adding > corresponding check_function_exists calls to that block, but they proved > ineffective; CMake evidently doesn't fall back on adding definitions to > the command line in the absence of a config header.
Adding " || defined(__FreeBSD_kernel__)" to the #elif statements in kpty.cpp should be sufficient to not need the CMakeLists.txt changes. Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
