On Sat, 07 May 2016 15:27:13 -0700, Sean Whitton wrote: > Debian::Control will fail to read source package control files if they > contain comments. This patch passes the stripComments option to > Parse::DebControl which deals with the problem.
Thanks for the bug report and the git-am-able patch!
In general this looks good, I've applied it locally and the tests
still pass. But there's a small "but": The tests pass, because they
don't have any control files/stanzas with comments. And if I add a
comment to t/Control.t:
#v+
diff --git a/t/Control.t b/t/Control.t
index 3927be3..ea40993 100644
--- a/t/Control.t
+++ b/t/Control.t
@@ -51,6 +51,7 @@ Package: libtest-compile-perl
Architecture: all
Depends: ${misc:Depends}, ${perl:Depends},
libuniversal-require-perl
+# This is a comment
Description: check whether Perl module files compile correctly
Test::Compile can be used in module test suites to verify that everything
compiles correctly. This description is artifitially prolonged, in order to be
#v-
then this test fails, because the written control "file" differs from
the read one; unsurprisingly, since the comment is missing.
One can argue that being able to read d/control with comments is an
improvement even if writing (on refresh e.g.) them swallows them; but
still, this doesn't feel totally right. -- Not sure what's the best
way forward here (libparse-debcontrol-perl also looks old and heavily
patched …).
Cheers,
gregor
--
.''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Led Zeppelin: Dazed And Confused
signature.asc
Description: Digital Signature
