Source: xsd
Version: 4.0.0-2
Severity: minor
Tags: patch
Control: found -1 4.0.0-5

Hi,

as a result of #795545, xsd can build with parallel jobs.
The downside of the implementation, as noted in its comment #22, is that
it unconditionally uses the number of processors, instead of respecting
the parallel=N configuration in DEB_BUILD_OPTIONS (see also
Policy ยง4.9.1).

The easy fix is to drop this additional logic, and let dh --parallel do
the right thing: the configured number of jobs (or 1 if not set) is used
for building, and when "make test" is executed later during
dh_auto_test.  Patch attached.

Thanks,
-- 
Pino
--- a/debian/rules
+++ b/debian/rules
@@ -15,25 +15,11 @@ export DH_OPTIONS
 #
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 
-#
-# Get the number of cpus
-#
-NO_CPUS=$(shell nproc)
-ifeq ($(NO_CPUS),0)
-NO_CPUS=1
-endif
-
 export verbose=1
 
 %:
 	dh $@ --with autotools-dev --parallel
 
-override_dh_auto_build:
-	make -j$(NO_CPUS)
-
-override_dh_auto_test:
-	make -j$(NO_CPUS) test
-
 override_dh_clean:
 	rm -f $(CURDIR)/libcult/build/system/configuration-dynamic.make
 	make xsd_clean_gen=n clean

Reply via email to