On Sun, Jan 15, 2006 at 04:24:17AM +0200, Recai Oktaş wrote:
> > I tested your code, and have one remark: you change tr_f -> f when
> > debian-installer/keymap is known, but you may also perform this
> > change after user selected a variant, he may get used to tr_f and
> > not know about this name change.
>
> You're right, the second patch is problematic. But as far as I can see it,
> the first one has not a flaw in this respect, since the TR handling code is
> in the:
>
> if [ -n "$RECONFIGURE" ] || [ -n "$FIRSTINST" ]; then
>
> body, before the db_inputs. Have I understood it correctly?
The problem is precisely that it appears before db_inputs. So if
XMAP is UNKNOWN, or if previous value was different from tr but
user selects tr this time, variant is not sanitized. Maybe this
sanitization could be performed at the end, just before writing
xorg.conf, to make sure that tr_{f,alt} variants are not written
into this file?
Denis
