On 16-04-25 10:38:20, Rene Engelhard wrote: > tag 792599 + moreinfo > thanks > > [ better late than nevr ] > > Hi, > > On Thu, Jul 16, 2015 at 05:28:44PM +0200, Dhole wrote: > > The attached patch removes timezone-varying timestamps from the > > files extracted with unzip. Once applied, openthesaurus can be > > built reproducibly in our reproducible toolchain. > [...] > > diff -Nru openthesaurus-20120516/debian/rules > > openthesaurus-20120516/debian/rules > > --- openthesaurus-20120516/debian/rules 2012-12-18 17:22:00.000000000 > > +0100 > > +++ openthesaurus-20120516/debian/rules 2015-07-15 19:34:30.000000000 > > +0200 > > @@ -51,7 +51,7 @@ > > > > mkdir -p > > $(CURDIR)/debian/openthesaurus-de-text/usr/share/openthesaurus-de/ > > cd $(CURDIR)/debian/openthesaurus-de-text/usr/share/openthesaurus-de && > > \ > > - unzip $(CURDIR)/text/OpenThesaurus-Textversion.zip openthesaurus.txt && > > \ > > + TZ=UTC unzip $(CURDIR)/text/OpenThesaurus-Textversion.zip > > openthesaurus.txt && \ > > ln -sf openthesaurus.txt thesaurus.txt > > > > install -D -m644 th_de_DE_v2.dat \ > > This is "just" the seconf unzip. I assume we should do it for the first > unzip (for the .oxt), too?
Hi! I only added the TZ=UTC to the second unzip because that's the one (openthesaurus.txt) I saw having a different timestamp in our Reproducible Builds infrastructure [1] [2]. But of course, adding the TZ=UTC to the first unzip is a good idea too, it certainly won't hurt :) [1] <https://reproducible.debian.net/dbd/unstable/amd64/openthesaurus_20120516-2.diffoscope.html> [2] <https://reproducible.debian.net/rb-pkg/unstable/amd64/openthesaurus.html> Cheers, -- Dhole
signature.asc
Description: PGP signature
