Package: staden
Version: 2.0.0+b10-4
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu xenial ubuntu-patch
Dear Maintainer,
staden currently has a number of implicit pointer conversions that can cause
serious issues with the package, especially on 64-bit architectures. You can
see the build log check errors here:
https://qa.debian.org/bls/packages/s/staden.html
In Ubuntu, the attached patch was applied to achieve the following:
* debian/patches/include_xalloc.patch: Include "xalloc.h" in a few more
files that use xcalloc.
Thanks for considering the patch.
Logan Rosen
-- System Information:
Debian Release: stretch/sid
APT prefers xenial-updates
APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500,
'xenial'), (100, 'xenial-backports')
Architecture: amd64 (x86_64)
Kernel: Linux 4.4.0-18-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru staden-2.0.0+b10/debian/patches/include_xalloc.patch staden-2.0.0+b10/debian/patches/include_xalloc.patch
--- staden-2.0.0+b10/debian/patches/include_xalloc.patch 1970-01-01 00:00:00.000000000 +0000
+++ staden-2.0.0+b10/debian/patches/include_xalloc.patch 2016-01-05 08:45:42.000000000 +0000
@@ -0,0 +1,31 @@
+Description: Include "xalloc.h" in a few more files that use xcalloc
+Author: Colin Watson <cjwat...@ubuntu.com>
+Forwarded: no
+Last-Update: 2016-01-05
+
+Index: b/hetins/hetins.c
+===================================================================
+--- a/hetins/hetins.c
++++ b/hetins/hetins.c
+@@ -9,6 +9,8 @@
+ #include <io_lib/Read.h>
+ #include <io_lib/traceType.h>
+
++#include "xalloc.h"
++
+ #define FULL_TEST 2
+ #define TEST 1
+
+Index: b/stops/stops.c
+===================================================================
+--- a/stops/stops.c
++++ b/stops/stops.c
+@@ -13,6 +13,8 @@
+ #include <io_lib/Read.h>
+ #include <io_lib/misc.h>
+
++#include "xalloc.h"
++
+ void do_nothing(void) {}
+
+ /* johnt 1/6/99 must explicitly import globals from DLLs with Visual C++*/
diff -Nru staden-2.0.0+b10/debian/patches/series staden-2.0.0+b10/debian/patches/series
--- staden-2.0.0+b10/debian/patches/series 2016-02-23 08:36:00.000000000 +0000
+++ staden-2.0.0+b10/debian/patches/series 2016-03-26 20:56:21.000000000 +0000
@@ -8,3 +8,4 @@
enable_setting_stadenroot.patch
spelling.patch
cope_with_modern_windowmanager.patch
+include_xalloc.patch
