Bug#822108: sshguard: Latest version (1.6.3-1) produces too many useless log entries, filling up /var

[Ximin Luo]

Ximin Luo:
> Since I upgraded to the new version sshguard has been polluting my auth.log 
> with
> useless entries of "Refreshing sources showed 0 changes." about 8 times per
> minute. Eventually this has caused my /var to fill up, after just a few days.
> This is very inconvenient; please just don't emit these entries.

Correction, this is actually 8 times *per second*. This really needs to be 
fixed with urgency.

I've attached a patch that suppresses the log entries, please apply it and also 
forward it upstream.

But it seems that sshguard is indeed doing something else 8 times a second that 
generates these entries too. I'm not sure if that's another bug; upstream will 
be able to judge this better.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git

--- a/src/sshguard_logsuck.c
+++ b/src/sshguard_logsuck.c
@@ -289,7 +289,9 @@
     }
     list_iterator_stop(& sources_list);
 
-    sshguard_log(LOG_INFO, "Refreshing sources showed %u changes.", numchanged);
+    if (numchanged > 0) {
+        sshguard_log(LOG_INFO, "Refreshing sources showed %u changes.", numchanged);
+    }
     return 0;
 }