Hello Ben, thanks for your update. There are only a few things left before we can upload the package. My main concern is the adventure-common binary package because I don't believe that shipping advent.dat with an extra package is very useful at the moment. As a compromise I offer you help in resolving future issues with possibly other adventure variants in Debian. However I expect that they will a) just ship the file with their own package and b) it is rather unlikely that we will see another implementation of the original adventure game in Debian. I think it is cool to have a modern Python3 version but it would be rather boring to have identical versions that simply reuse the same story from advent.dat.
Please fix colossal-cave-adventure.desktop: (found with desktop-file-validate) colossal-cave-adventure.desktop: error: (will be fatal in the future): value "colossal-cave-adventure.png" for key "Icon" in group "Desktop Entry" is an icon name with an extension, but there should be no extension as described in the Icon Theme Specification if the value is not an absolute path Please change the Vcs fields from: Vcs-Git: https://anonscm.debian.org/git/collab-maint/pkg-python-adventure.git Vcs-Browser: https://anonscm.debian.org/git/collab-maint/pkg-python-adventure.git to Vcs-Git: https://anonscm.debian.org/git/collab-maint/python-adventure.git Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/python-adventure.git so that the name of the git repository is identical to the source package name and that we use cgit for better performance. Please push the package to collab-maint next time and I will work and upload from there. Last but not least: There is a authoritative list of virtual package names (yeah, bureaucracy in Debian is wonderful) https://www.debian.org/doc/packaging-manuals/virtual-package-names-list.txt Please follow the procedure outlined in this text file and post to debian-devel and CC this RFS bug report. Personally I have no objections against using the adventure name but it is polite to inform fellow DDs too. Regards, Markus
signature.asc
Description: OpenPGP digital signature
