-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hello Bill,

On 09/04/16 13:36, Bill Allombert wrote:
> On Fri, Apr 01, 2016 at 04:22:03PM +0200, Jerome Benoit wrote:
>> Package: gap-core
>> Version: 4r7p5-2
>> Severity: normal
>>
>> Dear Maintainer,
>>
>>      the script /usr/share/gap/etc/convert.pl generates non-reproducible 
>> material.
>>      The involved code is:
>>
>> ===========8><----------------------------
>> # Printed at the bottom of every page.
>> $footer = "<P>\n" . sansserif( "GAP 4 manual<br>" . `date +"%B %Y"` ) .
>>           "</body></html>";
>> -----------><8============================
> 
> Hello Jerome,
> 
> I do not think this line is an issue but rather the one below:
>    $footer = "<P>\n<address>$opt_n manual<br>" .
>     `date +"%B %Y"` . "</address></body></html>";

the issue is the date arguments, and it was spot correctly.

> 
> I consider applying the attached patch.
> You just have to set the environment variable 'GAP_CONVERT_DATE'
> to the date which is listed in the upstream html files.
> 
> Does that work for you ? 

No, this does not work for me because it does not work for Debian:
no need to introduce a new environment variable (and certainly not a GAP one),
but instead the change must follow the  ReproducibleBuilds TimestampsProposal 
[1,2].

So, the subroutine "reprodate" must be slightly modified: numerous examples are 
available
via Debian Source [3]. Something as follows may be fine (see attachment):

sub reprodate
{
  return `date -u -d $ENV{'SOURCE_DATE_EPOCH'} +"%B %Y"` if 
(defined($ENV{'SOURCE_DATE_EPOCH'}));
  return `date +"%B %Y"`
}

Best wishes,
Jerome


[1] https://wiki.debian.org/ReproducibleBuilds/TimestampsProposal
[2] https://wiki.debian.org/ReproducibleBuilds/Howto
[3] http://sources.debian.net/


> 
> Cheers,
> Bill
> 
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJXCUwyAAoJEIC/w4IMSybjhxIH/3sUpeU+KAThSNiem8VkWkCy
xwbHGz47vN0eISz3WDJoseCvEAsyjqmUXZDmr92t7oRrVFJ6MTqjvbEyJFNwnqsQ
jvLMB6Qe3muFv0K5t5QXwzZyT5kOU5Li9OMrLmcrg7e+t71JU5dEytO7wgG1JOwG
8L0K9kWKQ2nnAudfJ7eHAHhLy1+r5C0ZXPRj9+ffWkK/vQJVAmUkm9l0zqST1DhU
fQEnu4j9p2tdO+vD4hZNDeOjWDjP0hwouQrztA+f6GHLZMhitaYqquvafK4qIBJ5
t8THMfffB6NpVUIv7nLreeeqs8+KOgGd2NlWyXkM5Fh6tYyb9l4/gNfqK3TYpiM=
=+VyB
-----END PGP SIGNATURE-----
#!/usr/bin/perl
##
## examples:
## $ ./adhoc
## $ SOURCE_DATE_EPOCH=@2147483647 ./adhoc

sub reprodate
{
return `date -u -d $ENV{'SOURCE_DATE_EPOCH'} +"%B %Y"` if 
(defined($ENV{'SOURCE_DATE_EPOCH'}));
return `date +"%B %Y"`
}

print &reprodate

# eos

Reply via email to