Package: release.debian.org Severity: normal Tags: jessie User: release.debian....@packages.debian.org Usertags: pu
Hi! I would like to fix #820342 [1] in stable, It is an upstream bug, which is already fixed upstream, and in the versions available in testing and unstable. Alert dialogs asking to send public GPG keys to servers or not results in sending both when pressing Yes, but also in those cases when you can close the alert dialog by pressing the window close button of the dialog, this also results in a yes. The patch fixes it by making only the yes button result in yes, and not "any button except the no button", which is the case in the version in stable. debdiff attached. 1: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=820342 -- System Information: Debian Release: 8.4 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=sv_SE.utf8, LC_CTYPE=sv_SE.utf8 (charmap=UTF-8)
diff -Nru gpa-0.9.5/debian/changelog gpa-0.9.5/debian/changelog --- gpa-0.9.5/debian/changelog 2014-09-25 17:04:38.000000000 +0200 +++ gpa-0.9.5/debian/changelog 2016-04-09 08:55:19.000000000 +0200 @@ -1,3 +1,9 @@ +gpa (0.9.5-2+deb8u1) jessie; urgency=high + + * Add patch fixing checks of dialog return values (Closes: #820342) + + -- Andreas Rönnquist <gus...@debian.org> Fri, 08 Apr 2016 21:25:19 +0200 + gpa (0.9.5-2) unstable; urgency=medium [ Daniel Kahn Gilmor ] diff -Nru gpa-0.9.5/debian/patches/fix_handling_of_confirmation_dialog.patch gpa-0.9.5/debian/patches/fix_handling_of_confirmation_dialog.patch --- gpa-0.9.5/debian/patches/fix_handling_of_confirmation_dialog.patch 1970-01-01 01:00:00.000000000 +0100 +++ gpa-0.9.5/debian/patches/fix_handling_of_confirmation_dialog.patch 2016-04-08 21:23:49.000000000 +0200 @@ -0,0 +1,34 @@ +Author: Wener Koch <w...@gnupg.org> +Description: Fix the handling of windows close button in confirmation dialogs. + * src/gpaexportserverop.c (confirm_send): Only act upon the Yes button. + * src/gpgmetools.c (check_overwriting): Ditto. + . + Checking for GTK_RESPONSE_NO was a bad idea because that catches only + the No button and no other events, like the window's close button. + . + Minor modification to make it apply to the version of GPA in Debian + Stable. +Origin: upstream, http://git.gnupg.org/cgi-bin/gitweb.cgi?p=gpa.git;a=commit;h=071ed43fac92c68c46a1a8fb19a435eebb8927e6 +Bug-Debian: http://bugs.debian.org/820342 +--- a/src/gpaexportserverop.c ++++ b/src/gpaexportserverop.c +@@ -133,7 +133,7 @@ + gtk_dialog_add_buttons (GTK_DIALOG (msgbox), + _("_Yes"), GTK_RESPONSE_YES, + _("_No"), GTK_RESPONSE_NO, NULL); +- if (gtk_dialog_run (GTK_DIALOG (msgbox)) == GTK_RESPONSE_NO) ++ if (gtk_dialog_run (GTK_DIALOG (msgbox)) != GTK_RESPONSE_YES) + { + gtk_widget_destroy (msgbox); + return FALSE; +--- a/src/gpgmetools.c ++++ b/src/gpgmetools.c +@@ -174,7 +174,7 @@ + gtk_dialog_add_buttons (GTK_DIALOG (msgbox), + _("_Yes"), GTK_RESPONSE_YES, + _("_No"), GTK_RESPONSE_NO, NULL); +- if (gtk_dialog_run (GTK_DIALOG (msgbox)) == GTK_RESPONSE_NO) ++ if (gtk_dialog_run (GTK_DIALOG (msgbox)) != GTK_RESPONSE_YES) + { + gtk_widget_destroy (msgbox); + return FALSE; diff -Nru gpa-0.9.5/debian/patches/series gpa-0.9.5/debian/patches/series --- gpa-0.9.5/debian/patches/series 2014-09-02 16:03:17.000000000 +0200 +++ gpa-0.9.5/debian/patches/series 2016-04-08 21:10:27.000000000 +0200 @@ -1,3 +1,4 @@ +fix_handling_of_confirmation_dialog.patch gnupg2.patch add_desktop_file_keywords.patch enable_cardman_close.patch
