Control: tags -1 -moreinfo +confirmed
On Fri, 2016-04-08 at 09:44 -0300, Herbert Fortes wrote:
> On Wed, 06 Apr 2016 21:33:47 +0100 "Adam D. Barratt"
> <a...@adam-barratt.org.uk> wrote:
> > Control: tags -1 + moreinfo
> >
> > On Tue, 2016-04-05 at 10:32 -0300, Herbert Parentes Fortes Neto wrote:
> > > Package nam[0] has a RC bug[1]. I did a NMU and
> > > it is on 'testing' (1.15-3.1).
> > >
> > >
> > > [0] - https://packages.qa.debian.org/n/nam.html
> > > [1] - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=784433
> > [...]
> > > + * debian/control:
> > > + - set tcl-dev and tk-dev to '>=8.6'.
> >
> > Apologies if I'm missing something, but where does the requirement for
> > 8.6 come from? The only reference to 8.6 I can find in the source
> > package is in the changelog and the strings quoted in the bug report
> > don't appear in the nam source package in stable.
>
> I did a 'grep -r' and did not find it either. But I installed
> the package again (in a clean stable - VM-KVM) and I
> received the same message. It does not run. Another user
> sent me a email talking about the same problem.
Fun. :-( I believe it's a problem, I just wish I understood more about
why...
[...]
> > > + * debian/patches:
> > > + - init_tcltk_with_stub.diff unused. Commented (#) in series file.
> >
> > If it's uncommented in the series file, then it's not "unused", surely?
> >
>
> It is commented, I put a '#' at the beginning of the line:
It is *now*, yes. You said "unused", which implied that it was unused
_before_ you commented it out.
(Incidentally, I'm quite aware of how patches are commented out in
series files. :-P)
> It calls Tcl_InitStubs and Tk_InitStubs functions. The
> manpage[0][1] says:
>
> "...Zero means that versions newer than version are also
> acceptable as long as they have the same
> major version number as version."
[...]
> I did a 'apt-get source nam', 'apt-get build-dep nam'. Without
> changing anything, 'debuild'. The 'dpkg -I' inform libtcl8.6
> and libtk8.6. But, after install, when I try to run 'nam',
> I receive a 'segmentation fault'.
The patch appears to have been added as part of:
nam (1.15~RC4-4) unstable; urgency=low
* Patch to restrict version depend on tk (Closes: #620093)
Whether it work should be test: init_tcltk_with_stub.diff.
[...]
* debian/rules:
- add -ltclstub8.x and -ltkstub8.x to link against stub.
-- YunQiang Su <wzss...@gmail.com> Fri, 03 Jun 2011 01:50:10 +0800
Reading through the log for that bug, I suspect this change:
tclcl (1.20~RC3-4) unstable; urgency=low
* Patch Makefile.in to remove "-exact" require tcl and tk.
made the stub changes unnecessary. The debian/rules changes also seem to
have been reverted at some point, without being explicitly mentioned (it
may be part of "Rewrite build system with CMake" a few months later).
All in all, I'm still not entirely sure that the changes are completely
correct, but on the assumption that there have been no issues since they
were applied in unstable, please go ahead and we'll keep our fingers
crossed. :-|
Regards,
Adam
