Control: severity -1 wishlist
Control: tags -1 + moreinfo
On 2016-03-28 09:39 +0900, Roger Shimizu wrote:
> Package: src:ncurses
> Severity: normal
> Tags: patch, d-i
> X-Debbugs-Cc: rogershim...@gmail.com
>
> Dear Maintainer,
>
> I'm trying to port GNU/screen to debian-installer [0].
> GNU/screen depends on your library, so enclosed the patch I created to
> make those udeb support.
>
> I hope you can merge my patch soon. Thank you!
There are various things wrong with it, unfortunately.
> +Package: libtinfo5-udeb
> +XC-Package-Type: udeb
Please use Package-Type rather than XC-Package-Type.
See "lintian-info -t xc-package-type-in-debian-control".
> +Section: debian-installer
> +Architecture: any
> +Pre-Depends: ${misc:Pre-Depends}
Uhm, why Pre-Depends?
> +Multi-Arch: same
It does not really make sense to mark udebs as "Multi-Arch: same" since
you won't be using more than one architecture in the installer.
> +Depends: ${misc:Depends}
> +Description: shared low-level terminfo library for terminal handling - udeb
> + The ncurses library routines are a terminal-independent method of
> + updating character screens with reasonable optimization.
> + .
> + This package contains the stripped-down udeb version of shared low-level
> + terminfo library.
> +
> Package: libncurses5
> Architecture: any
> Pre-Depends: ${misc:Pre-Depends}
> diff --git a/debian/libtinfo5-udeb.install.in
> b/debian/libtinfo5-udeb.install.in
> new file mode 100644
> index 0000000..b0b4373
> --- /dev/null
> +++ b/debian/libtinfo5-udeb.install.in
> @@ -0,0 +1,2 @@
> +usr/lib/${DEB_HOST_MULTIARCH}/libtinfo.so.* lib/${DEB_HOST_MULTIARCH}
> +usr/lib/${DEB_HOST_MULTIARCH}/libtic.so.*
I would just install all libraries into lib, and then you don't need to
use a libtinfo5-udeb.install.in file.
Most importantly, you need to generate udeb lines in the libtinfo5
shlibs file, so that udebs with programs linked against libtinfo depend
on libtinfo5-udeb rather than libtinfo5. To achieve that, pass
"--add-udeb" in the dh_makeshlibs call for libtinfo5 in debian/rules.
Cheers,
Sven
