I would have appreciated that the patches were committed to the
packaging repository **with** authorship information:
here:
https://anonscm.debian.org/git/collab-maint/libjsoncpp.git/commit/?id=b832e69d7861b412f93510dcd57df7b6e70e9fc6
and here:
https://anonscm.debian.org/git/collab-maint/libjsoncpp.git/commit/?id=e0f7dd90905dfe418a58bd5c37d5cbbce2fe8cd8
I guess it is too late now, but please be careful in the future. Thanks
for crediting my work in the changelog though.
Ghis
On 28/03/16 03:50, Peter Spiess-Knafl wrote:
Hi Ghis!
Thank you for your patch. I applied it in the git repo, an upload will
follow soon.
It really makes things much easier, thank you!
Greetings
Peter
On 03/27/2016 09:43 PM, Ghislain Vaillant wrote:
Package: libjsoncpp
Version: 1.6.5-4
Dear maintainer,
Whilst using your package, I noticed that the CMake package files
were not installed in a multi-arch enabled location of the form:
/usr/lib/<multiarch-triplet>/cmake/<package-name>
I am forwarding a patch to the packaging repository which addresses
this.
I also took this opportunity to significantly simplify multi-arch path
injection to the build system. So far, this was handled by patching the
sources (last resort solution) whilst the upstream build system does
provide overridable CMake variables for this purpose. This patch uses
these variables instead and drops the corresponding patches from the
patch-queue.
A successful build with the applied patch is available here:
http://debomatic-amd64.debian.net/distribution#unstable/libjsoncpp/1.6.5-4.1/buildlog
Best regards,
Ghis
