Package: apq
Version: 3.2.0-2
Severity: important

Dear maintainer:

While building this package with "dpkg-buildpackage -A", I noticed that
the build system does not check for errors as required by Policy 4.6
(this is a policy "must" directive).

Compare the following build logs.

In the first one, some kind of error happened:

  I can't find the format file `pdflatex.fmt'!
  Error while building PDF file

but the build continued anyway and created an incorrect package.
This is easy to check by doing this:

$ grep manual.pdf.gz apq_3.2.0-2_amd64-20160227-0231
[ no output ]

$ grep manual.pdf.gz apq_3.2.0-2_amd64-20160307-1400
-rw-r--r-- root/root    613538 2016-03-07 14:01 
./usr/share/doc/libapq-doc/manual.pdf.gz

The attached patch should probably fix this bug, by not hiding the
errors when they happen.

Thanks.

Attachment: apq_3.2.0-2_amd64-20160227-0231.gz
Description: application/gzip

Attachment: apq_3.2.0-2_amd64-20160307-1400.gz
Description: application/gzip

--- a/manual/Makefile
+++ b/manual/Makefile
@@ -3,7 +3,7 @@
 all: manual.pdf
 
 %.pdf: %.tex
-       pdflatex -halt-on-error $< && pdflatex -halt-on-error $< || echo Error 
while building PDF file
+       pdflatex -halt-on-error $< && pdflatex -halt-on-error $<
 
 
 clean: manual.pdf-clean

Reply via email to