Source: shadow Version: 1:4.2-3.1 Severity: normal Tags: patch User: [email protected] Usertags: environment
Hi, While trying to debug why shadow was *not* reproducible, we discovered that it captures the "SHELL" variable of the builder and uses that as the "last resort" shell. This might be fine for personal builds, but I think that a distrobution build should pick a well-defined default, which is always available. In the attached patch, I picked "/bin/bash" (but I believe "/bin/sh" would be quite acceptable too). Thanks, ~Niels
>From 1d81ce999de214481a45d962a8ad03de22d293e4 Mon Sep 17 00:00:00 2001 From: Niels Thykier <[email protected]> Date: Sat, 12 Mar 2016 08:13:57 +0000 Subject: [PATCH] d/rules: Explicitly set SHELL to /bin/bash Otherwise, configure will derive it from the environment and the package then differs based on the shell used by the builder. Signed-off-by: Niels Thykier <[email protected]> --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index 51c0f5d..1519c38 100755 --- a/debian/rules +++ b/debian/rules @@ -19,7 +19,7 @@ DEB_DESTDIR=$(CURDIR)/debian/tmp include /usr/share/cdbs/1/class/autotools.mk # Adds extra options when calling the configure script: -DEB_CONFIGURE_EXTRA_FLAGS := --disable-shared --without-libcrack --mandir=/usr/share/man --with-libpam --enable-shadowgrp --enable-man --disable-account-tools-setuid --with-group-name-max-length=32 --without-acl --without-attr --without-tcb +DEB_CONFIGURE_EXTRA_FLAGS := --disable-shared --without-libcrack --mandir=/usr/share/man --with-libpam --enable-shadowgrp --enable-man --disable-account-tools-setuid --with-group-name-max-length=32 --without-acl --without-attr --without-tcb SHELL=/bin/bash ifneq ($(DEB_BUILD_GNU_TYPE),$(DEB_HOST_GNU_TYPE)) DEB_CONFIGURE_EXTRA_FLAGS += --host=$(DEB_HOST_GNU_TYPE) endif -- 2.7.0
