On 06-Mar-2016, efkin wrote: > This should fix email headers that were not > properly rendered.
Thank you, efkin, for making a patch. I think that is addressing the problem in the wrong place. The template tag should not do any encoding. Instead, it should just do template interpolation, and return the Unicode text. Encoding that text for transmission should be done only after the whole message is composed. So I think the correct solution entails: * In ‘backend.templatetags.nm.formataddr’, remove the ‘encode’ call. * In ‘backend.email.send_notification’, encode all fields of the header (using ‘email.header.Header’ as you suggest). -- \ “The history of Western science confirms the aphorism that the | `\ great menace to progress is not ignorance but the illusion of | _o__) knowledge.” —Daniel J. Boorstin, historian, 1914–2004 | Ben Finney <b...@benfinney.id.au>
signature.asc
Description: PGP signature
