Hi, El 05/03/16 a las 17:24, efkin escribió: > Hi, > > i've digged a little bit in the code and imho the email notification > feature is correctly implemented. > > What i found instead is that there is a little constraint when this > notification should be sent. Basically only from "Advocacies have been > approved" status to "Wating to AM to confirm" status this notification > is sent. >
I didn't still get that mail about my last NM, even if the timeline fits your analysis: 2016-02-14 jmw Activity poll sent Resent activity poll 2016-02-19 jmw Advocacies have been approved 2016-02-19 jmw Waiting for AM to confirm Assigned to santiago 2016-02-22 santiago Interacting with an AM And I can see in the mail archive that the corresponding message: From: Jonathan Wiltshire via nm <j...@debian.org> To: Santiago Ruano Rincxf3n <santi...@debian.org> I wonder if nm.d.o is not correctly handling the diacritic in my last name, look at the "Rincxf3n". I wouldn't be surprised that encoding is challenging this also (see https://bugs.debian.org/744077). I'd say we still live in a not fully unicode-compliant world. > My claim is basically that in a workflow level users are not so accurate > and the code could take care of it. > > In the attached patch i propose to relax this constraint and notify, > for completeness, the admin that is trying to assign an AM, that some > steps are being skipped. > > Sorry for my terrible english. > Even if you English was bad, you shouldn't be sorry. > Bests, > > efkin. Thanks for looking into this, Santiago
