Package: git-buildpackage
Version: 0.6.22
Followup-For: Bug #692803

Dear Maintainer,

/usr/bin/git-pbuilder contains:
> 266 # Add all of the additional arguments we got on the command line, but 
> quote
> 267 # them from the shell since they'll undergo another round of shell 
> expansion
> 268 # when the pbuilder runs debbuild.
...
> 270 for arg in "$@" ; do
...
> 274     DEBBUILDOPTS+=" $(shell_quote "$arg")"
> 275 done

This seems to be right only when *not* using --use-pdebuild-internal, as

/usr/lib/pbuilder/pdebuild-checkparams:
>  44 »···--debbuildopts)
>  45 »···    DEBBUILDOPTS="${2:+$DEBBUILDOPTS $2}"
passes the argument unmodified, but then

/usr/bin/pdebuild:
>  46 if [ "${USE_PDEBUILD_INTERNAL}" = 'yes' ]; then
>  57 »···--debbuildopts "${DEBBUILDOPTS}" \
passes on the argument unmodified when using the internal pdebuild, but

>  74 else
>  78     echo "dpkg-buildpackage -S -us -uc -r${BUILDSOURCEROOTCMD} 
> $DEBBUILDOPTS" | \
>  80 »···/bin/bash
does splitting on IFS when not using it.
>  90 fi


For completeness:

/usr/lib/pbuilder/pdebuild-internal:
>  48 »···--debbuildopts)
>  50 »···    DEBBUILDOPTS="${2:+${DEBBUILDOPTS:+$DEBBUILDOPTS }$2}";
un-splitted
> 123 export DEBBUILDOPTS
> 124 CMD="/usr/bin/dpkg-buildpackage -rfakeroot -us -uc "'${DEBBUILDOPTS}'
> 128 if echo "$CMD" | \
> 129     su -p pbuser;·

does *not* spit on IFS, so DEBBUILDOPTS still contains the 's from 
shell_quote() leading to the error

> I: Running /usr/bin/dpkg-buildpackage -rfakeroot -us -uc ${DEBBUILDOPTS}
> dpkg-buildpackage: unknown option or argument '-sa'
>
> Use --help for program usage information.

Philipp

PS: I still wonder why --use-pdebuild-internal is not the default, as I
don't want to pollute my development environment with all those build
dependencies. That makes running "debian/rules clean" sometimes more
complicate as I'm missing some required dependencies for that, but
still..."
-- System Information:
Debian Release: 8.3
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (90, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages git-buildpackage depends on:
ii  devscripts            2.15.3
ii  git                   1:2.1.4-2.1+deb8u1
ii  man-db                2.7.0.2-5
ii  python                2.7.9-1
ii  python-dateutil       2.2-2
ii  python-pkg-resources  5.5.1-1

Versions of packages git-buildpackage recommends:
ii  cowbuilder    0.73
ii  pristine-tar  1.33

Versions of packages git-buildpackage suggests:
pn  python-notify  <none>
ii  unzip          6.0-16+deb8u2

-- no debconf information

Reply via email to