> On Mon, Feb 15, 2016 at 7:12 PM, Ritesh Raj Sarraf wrote: > >> I checked the git log. Both directories are added there. >> >> self.defaultPaths = ['/etc/apt/trusted.gpg.d/', '/usr/share/keyrings/'] >> >> I'm not sure if it was you who suggested /u/s/k, or Hans Steiner, or >> someone else; but it is already there in master branch and 1.7. > > Here is the commit where you added that: > > https://anonscm.debian.org/cgit/apt-offline/apt-offline.git/commit/?id=c4f9b71d611a6085c33905a7575fa199b1faa15c > > It references this bug report by me: > > https://bugs.debian.org/747163 > > The bug doesn't mention /u/s/k so it must have been Hans who > incorrectly suggested that. > > BTW, I suggest you write more verbose git logs so you can explain > decisions like this just from the git log. The Linux kernel git logs > are a pretty good example of how to do it. > > -- > bye, > pabs > > https://wiki.debian.org/PaulWise
And yes, I proposed adding /usr/share/keyrings as part of `apt-offline install` (which copies the files from the thumb drive to the offline machine) based on my experience with `debootstrap`, which does use a file in /usr/share/keyring. Glad to see that's improved, but FYI, in terms of apt-offline, this is only related to an added level of verification on top of what `apt-get install` does. https://anonscm.debian.org/cgit/apt-offline/apt-offline.git/commit/?id=77b6b460ced7aeb7f69d470d5fe34ac500faad7b `apt-offline` just shuffles files around, it does not do the package installing. `apt-get install` does that, and `apt-get install` is what is verifying the packages before installing them. The final steps of the apt-offline workflow look like this: apt-offline install /media/thumb/bundle.zip apt-get install openjdk-7-jdk .hc