On Mon, Feb 22, 2016 at 4:30 AM, Steven Chamberlain <ste...@pyro.eu.org> wrote: > Aaron M. Ucko wrote: >> Builds of zeromq3 for kFreeBSD are now failing with >> src/ipc_listener.cpp: In member function 'bool >> zmq::ipc_listener_t::filter(zmq::fd_t)': >> src/ipc_listener.cpp:263:19: error: aggregate >> 'zmq::ipc_listener_t::filter(zmq::fd_t)::xucred cred' has incomplete type >> and cannot be defined >> struct xucred cred; >> ^ >> src/ipc_listener.cpp:268:28: error: 'XUCRED_VERSION' was not declared in >> this scope >> if (cred.cr_version != XUCRED_VERSION) >> ^ > > It was just a missing #include. Please find patch attached > (sys_ucred_h.patch). Thanks, this looks sane. Would you submit it to upstream or should I do it?
> There were some other issues on kfreebsd at run-time: > > | FAIL: test_system > | ================= > | > | Function not implemented (src/thread.cpp:135) > | FAIL test_system (exit status: 134) > > most tests were failing that way. GNU/kFreeBSD doesn't implement > pthread_setschedparam yet, so I think we should gracefully ignore ENOSYS > instead of aborting. Do you think that something similar may happen on Linux machines as well? > With that fixed, another error was. > > | FAIL: test_shutdown_stress > | ========================== > | > | Connection reset by peer (src/stream_engine.cpp:162) > | FAIL test_shutdown_stress (exit status: 134) > > The other patch (kfreebsd-support.patch) fixes all these things, and all > tests pass for me now on kfreebsd-amd64. How did you test it? Simple chroot or pbuilder building? The Linux self-test failures, aborts happen on all archtectures. However I couldn't reproduce those in a dirty chroot to a clean pbuilder build process, neither on amd64 nor on i386. But on buildds it happens all the time. :( Thanks, Laszlo/GCS
