Package: src:passenger
Version: 5.0.22-1
Severity: important
Tags: patch
Control: block 815242 by -1
Hi,
As per Policy 4.13:
"Debian packaging should ensure that binary packages reference the
libraries already in Debian and the convenience copy is not used"
https://www.debian.org/doc/debian-policy/ch-source.html#s-embeddedfiles
The passenger source package contains a copy of libuv in
src/cxx_supportlib/vendor-copy/ - as far as I know, unmodified.
The library is already packaged in Debian. Please could you use that
instead? The Debian package may receive bug fixes or security patches
over time, whereas code copies bundled with passenger may not.
Already, the Debian libuv package has portability fixes allowing it to
build on kfreebsd, which the bundled code copy does not have.
The attached patch selects the system libuv. (false = system library,
true = bundled code copy) Please also add libuv1-dev to Build-Depends.
Thank you.
-- System Information:
Debian Release: stretch/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: kfreebsd-amd64 (x86_64)
Kernel: kFreeBSD 10.1-0-amd64
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
--- a/build/basics.rb
+++ b/build/basics.rb
@@ -227,4 +227,4 @@
# Whether to use the vendored libev or the system one.
USE_VENDORED_LIBEV = boolean_option("USE_VENDORED_LIBEV", true)
# Whether to use the vendored libuv or the system one.
-USE_VENDORED_LIBUV = boolean_option("USE_VENDORED_LIBUV", true)
+USE_VENDORED_LIBUV = boolean_option("USE_VENDORED_LIBUV", false)
