Jérémy Bobbio wrote: > Steven Chamberlain: > > But it will still stat() everything in the containing directory, > > looking for .debs. It also opens some files and reads them - even > > decompressing random .gz files along the way! > > Are you sure that it is actually decompressing files and not just > identifying them?
Ah okay, it reads just one block to check its file magic, I think.
> Anyway, I've just pushed another patch to filter by filenames before
> looking at content. This should further improve the situation.
I don't think it worked? It's still doing as before, looking at
text, gzip files and validating the sha1sums in a .buildinfo:
| DEBUG Looking for a dbgsym package for Build Id
4bfc8175c9c53156a7e20d0216bc9fff0d25ae2a (debuglink:
fc8175c9c53156a7e20d0216bc9fff0d25ae2a.debug)
| DEBUG Using TextFile for a/build/.bash_logout
| DEBUG Using TextFile for a/build/.bashrc
| DEBUG Using TextFile for a/build/.profile
| DEBUG Using DebFile for a/build/cpp-4.9-dbgsym_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for a/build/cpp-4.9_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for a/build/g++-4.9-dbgsym_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for a/build/g++-4.9-multilib_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for a/build/g++-4.9_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for a/build/gcc-4.9-base_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for a/build/gcc-4.9-dbgsym_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for a/build/gcc-4.9-locales_4.9.3-11_all.deb
| DEBUG Using DebFile for a/build/gcc-4.9-multilib_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for
a/build/gcc-4.9-plugin-dev-dbgsym_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for a/build/gcc-4.9-plugin-dev_4.9.3-11_kfreebsd-amd64.deb
| DEBUG Using DebFile for a/build/gcc-4.9-source_4.9.3-11_all.deb
| DEBUG Using GzipFile for a/build/gcc-4.9_4.9.3-11.diff.gz
| DEBUG Using DotDscFile for a/build/gcc-4.9_4.9.3-11.dsc
| DEBUG Using DotBuildinfoFile for
a/build/gcc-4.9_4.9.3-11_kfreebsd-amd64.buildinfo
| DEBUG validating sha1 checksums
and I'm pretty sure I used current Git master:
| grep -n -C2 irrelevant
/usr/lib/python3/dist-packages/diffoscope/comparators/deb.py
| 40- for member_name, member in container.get_members().items():
| 41- # Let's assume the name will end with .deb to avoid looking at
| 42: # too many irrelevant files
| 43- if not member_name.endswith('.deb'):
| 44- continue
Regards,
--
Steven Chamberlain
ste...@pyro.eu.org
signature.asc
Description: Digital signature
