On Wed, Feb 10, 2016 at 09:44:09PM +0000, Jose M Calhariz wrote: > One more interation.
uops!
This slipped off my sight, sorry for the delay! :|
> On 08/02/16 21:57, Mattia Rizzolo wrote:
> > On Mon, Feb 08, 2016 at 09:29:55PM +0000, Jose M Calhariz wrote:
> >> Today I didn't review all yours remarks. But in the spirit of release
> >> early and release often here goes my today effort.
> > yay, I definitely approve this ;)
> > I hadn't gone deeper, just commented on your last changes here.
> >
> >> On 07/02/16 22:01, Mattia Rizzolo wrote:
> >>> On Sun, Feb 07, 2016 at 08:40:10PM +0000, Jose M Calhariz wrote:
> >>>> On 06/02/16 23:41, Mattia Rizzolo wrote:
> >>>>> Umh, couldn't you turn d/rules to use the dh sequencer?
> >>>> I don't know enough and lintian show many problems with upstream d/rules.
> >>> well, let's fix them, then :)
> >>> Attached there is a d/rules using short dh, may you try it and bend it
> >>> better to the needs of this package?
> >> I managed to make it compile, but for a reason I don't know I needed to
> >> add the following lines:
> >>
> >> override_dh_auto_configure:
> >> cp /usr/share/misc/config.guess .
> >> cp /usr/share/misc/config.sub .
> >> dh_auto_configure --parallel
> > that's so weird.
> >
> > even more in light of the new dh_update_autotools_config which is run
> > automatically by dh >= 9.20160114 and do exactly that.
> > Are you testing your package in an update sid chroot?
> >
> >> I have tried many ideas but was only this way that it build
> > also, it did build here without them.
>
> As you may see in d/rules, I found another workaround. This time I
> believe that is correct.
umh, that is so tautological and useless :)
So, you are telling dh_clean to remove those files in debian/clean, just
to leter tell it telling to *not* remove those 2 in debian/rules!
Just remove those config.{sub,guess} from debian/clean, and it should be
just fine.
And while on it also remove 'configure' and 'libtool' from d/clean, no
need to remove them.
d/clean is to remove files created a build time and not cleaned up by
the build system, this is not the case here. And I have the impression
there are several other useless entries there.
And while you are cleaning useless files up, now the
override_dh_auto_configure is useless too.
Then sawfish-lisp-source.dirs is empty, remove it;
and please check whether all the entries on sawfish.dirs are needed or
not; I can count on a single hand the occasions where a debian/*.dirs
file was really needed, remember that files copied by dh tools don't
need it.
> I have reviewed all the bugs, so I am closing what I more certain that
> is fixed by 1.11.
cool!
In nearly 10 days of pause I forgot almose everything I wrote here…
I hope later today to be able to review everything again and provide you
with a list of stuff.
I also saw you tried to do the symlink_to_dir thinghy, I'll check if
more is needed.
Thank you for your work, and sorry it took so long to get back at you!
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
