On 20-Oct-2015, Guido Günther wrote: > Hi, > On Mon, Oct 19, 2015 at 06:27:34PM +1100, Ben Finney wrote: > > I would expect ‘git-buildpackage’ should as closely as feasible > > mirror the overlay behaviour of the original ‘svn-buildpackage’, > > and later ‘bzr-buildpackage’ and ‘hg-buildpackage’. > > > > That includes, AFAICT, constructing the overlaid source tree, then > > calling ‘debian/rules clean’ (maybe using ‘dpkg-source’ to do it) > > inside the resulting source tree, before continuing the build. > > I'd be happy to apply a patch to achieve this behaviour. Given that > I'm not a overlay user myself and currently stall on other things > already.
I have implemented this behaviour and it seems to work correctly. Please merge from my ‘issue/802284-overlay-before-rules’ branch <URL:https://notabug.org/bignose/debian_git-buildpackage/src/issue/802284-overlay-before-rules> if you approve of the implementation. > A testcase using e.g. tests/component/deb/test_buildpackage.py > to make sure it doesn't get broken again would be welcome too. I was not able to figure out the test suite enough to make a test case. I have started a discussion separately for that. -- \ “They who can give up essential liberty to obtain a little | `\ temporary safety, deserve neither liberty nor safety.” | _o__) —Benjamin Franklin, 1775-02-17 | Ben Finney <b...@benfinney.id.au>
signature.asc
Description: PGP signature
