Hello Michael Prokop. On Sat, Jan 23, 2016 at 12:07:58AM +0100, Michael Prokop wrote: > I've worked on a patch for file-rc which takes care of diverting the > relevant invoke-rc.d. + update-rc.d files (following instructions as > documented at > https://www.debian.org/doc/debian-policy/ap-pkg-diversions.html), so > file-rc can be co-installed with init-system-helpers >=1.25. >
Thanks for looking into this. > I'd highly appreciate a review and if there are no objections I'd > upload this then. Overall looks good to me and seems to install fine in a container here (after init-system-helpers has been rebuilt with a versioned conflict). There's one question on my mind though, shouldn't the upgrade case be versioned? eg. so in additional future releases you don't try to divert when you've already diverted. You only want the diversion to happen once when upgrading to this exact version you're preparing now. Regards, Andreas Henriksson