-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

according to titanpad:
https://titanpad.com/libpng16-transistion



> The package already build-depends on libz1g-dev, so zlib.h should
> be reachable in the build context, and I do not understand fully
> why
maybe it isn't included in the .c or .h file?

### Missing zlib.h include ###
error: 'Z_DEFAULT_COMPRESSION'   -- might be fixed by including zlib.h
error: 'ZLIB_VERSION' undeclared (first use in this function)

> "setjmp should be fixed", since the build reports at 
> https://buildd.debian.org/status/package.php?p=openlayer are all 
> positive.
> 

### Not using getters/setters for lib png structs ###
dereferencing pointer to incomplete type 'png_struct'

Example: setjmp
+        if (setjmp(png_jmpbuf((theWritePtr))))
- -         if (setjmp(theWritePtr->jmpbuf))


cheers,

Gianfranco
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJWohHfAAoJEPNPCXROn13ZjpsQALLCtO7wpOco0XD8xmOcE8tw
TmD8iW1nXcSUkkUJJT0cBGk5lyiQpYojtzc070LHetd3JbZmTNXKuU83tTH/G7FB
upy9huv674uwLDY4hievkplRFZCFDUOv5vOUNQVQBTYHDOijSfFMQEEMTTaGCsEE
hDezXM12wDaXVyzHtzsfZqQlpNg9/UZ4uZTZmJTmkIKGT6LunbsAPEupnzokcvc8
YZzZsiQvOtCrNlKgP0rgxe7S7Cw3tjX/dttkr6hS7Y+22PCbbZCz6ClQEu5etC1Q
UcOze8u4IEw+40OLtEt2TcGEugzAp0IlJ4Nw3RQ0oH+Ulr2fAmw9SJq3v4Z3MroL
pY6OSl9UnLSTbPF/87muO2bZYFH4YaWnDt0D/8dz0WLTJaR5W7TRBTUmg8yYjP5+
ZmwpSCF7vakkG0Nzb+EZ4hbvg6MoagJP19WuJZ4S8/oB4PkSGAiwKCtAoarAF1HK
Xr1i8Ma6ShUiqHV/EnytmZ6sMMYK7xVuV/rHzTT7zDDuSI8hO+HJAHxjDfSO8pZA
PjLyjbEHgzIovFMQIy/X5nNyHQNbCXprcs7fF02aQIoH6kUya1/b4SwJIRGBEES9
Ki2iUtdaSABOzClsH4J3e7LYNu+cm5fACJ0KOZlZ9mqFruToo5AZsmV5oHEdzveI
odNNLGjI9ic1/YybxMat
=vYXd
-----END PGP SIGNATURE-----

Reply via email to