Bug#812170: qrouter: FTBFS using clang instead of gcc

[Arthur Marble]

Package: qrouter
Severity: minor
Tags: patch
User: pkg-llvm-t...@lists.alioth.debian.org
Usertags: clang-ftbfs

Hello,

Using the rebuild infrastructure, your package fails to build with clang
(instead of gcc).

Detected this kind of error:
http://clang.debian.net/status.php?version=3.6.0&key=FUNCTION_RETURNS_VALUE

Full build log is available here:
http://clang.debian.net/logs/2015-03-25/qrouter_1.3.3-1_unstable_clang.log

I have attached a patch to fix this error.

Regards,
--Arthur Marble


-- System Information:
Debian Release: sid (unstable)
Architecture: amd64 (x86_64)
Kernel: Linux 4.2.0-1-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE="en_US.UTF-8"
Shell: /bin/sh linked to /bin/dash
Compiler: Debian clang version 3.6.2-3 (based on LLVM 3.6.2)

--- a/qrouter.c
+++ b/qrouter.c
@@ -68,7 +68,7 @@
 {
    int i;
 
-   if (NumChannelsX[0] != 0) return;	/* Already been called */
+   if (NumChannelsX[0] != 0) return 1;	/* Already been called */
 
    for (i = 0; i < Num_layers; i++) {
       if (PitchX[i] == 0.0 || PitchY[i] == 0.0) {
@@ -108,7 +108,7 @@
 {
    int i;
 
-   if (Obs[0] != NULL) return;	/* Already been called */
+   if (Obs[0] != NULL) return 1;	/* Already been called */
 
    for (i = 0; i < Num_layers; i++) {
       Obs[i] = (u_int *)calloc(NumChannelsX[i] * NumChannelsY[i],
--- a/graphics.c
+++ b/graphics.c
@@ -488,7 +488,7 @@
    tktop = Tk_MainWindow(interp);
    if (tktop == NULL) {
       tcl_printf(stderr, "No Top-level Tk window available. . .\n");
-      return;
+      return 3;
    }
 
    qrouterdrawwin = (char *)Tcl_GetVar(interp, "drawwindow", TCL_GLOBAL_ONLY);