control: tag -1 patch [ umh, you didn't CCed me, it's hard to notice reply without receving emails ;) anyway, I just subscribed the bug, for both convenience ]
On Thu, Jan 14, 2016 at 07:37:23AM +0100, Michael Hanke wrote:
> This dependency setting is motivated by the need for 'dicom.dic' which
> has moved a lot in the past. Currently
it simply moved with the library soname change.
>
> % apt-file search dicom.dic
> libdcmtk2: /usr/share/libdcmtk2/dicom.dic
> libdcmtk2v5: /usr/share/libdcmtk2/dicom.dic
> libdcmtk4v5: /usr/share/libdcmtk4/dicom.dic
note that all these 3 packages above are not builded anymore, and holded
just by cruft in the archive.
> libdcmtk5: /usr/share/libdcmtk5/dicom.dic
this is the current one. And I'd expect it to change again in the
future.
all those package were dependency of the libdcmtk-dev of the moment.
> This is required for the tests to run. This package is often backported
> and it would be a hassle to have to modify it for each an every target.
well, currently you are changing the build-dep of the unstable package
every so often to follow this...
So, the problem is that you hard code that path above in d/rules, for a
package that otherwise doesn't.
For curiosity, I tried to just remove that variable declaration, and it
just works, calling `make check` seems like the program figures the
right thing alone.
> If you have a suggestion on how to do this better, I'd be happy to
> implement it.
I just tried a build of the current unstable package (wow — it's a long
build for a just 2MB package! :D) using my suggestion (also attached),
and it just worked.
Also, that wasy I wouldn't see any problem during backports build,
libdcmtk-dev would just pick up whatever version of libdcmtk is in that
suite. That's the normal behaviour of libraries... (even if usually lib
binaries don't ship stuff in /usr/share. And usually stuuff in
/usr/share is not in versioned directories, but I don't know how dcmtk
works)
> At the moment I don't see how this bug is severity
> important.
you build-depend on a package that is basically kept in the archive just
for you... (as the other 2 packages holding it are only because they
can't currently be rebuilt since they already FTBFS).
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
diffstat for odin-1.8.8 odin-1.8.8 changelog | 6 ++++++ control | 4 +--- rules | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff -Nru odin-1.8.8/debian/changelog odin-1.8.8/debian/changelog --- odin-1.8.8/debian/changelog 2015-12-06 19:06:11.000000000 +0000 +++ odin-1.8.8/debian/changelog 2016-01-16 02:14:43.000000000 +0000 @@ -1,3 +1,9 @@ +odin (1.8.8-2.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + + -- Mattia Rizzolo <mat...@debian.org> Sat, 16 Jan 2016 02:14:41 +0000 + odin (1.8.8-2) unstable; urgency=medium * Switch to using dh-autoreconf. Thanks to Bas Couwenberg for the nudge. diff -Nru odin-1.8.8/debian/control odin-1.8.8/debian/control --- odin-1.8.8/debian/control 2015-12-06 19:03:01.000000000 +0000 +++ odin-1.8.8/debian/control 2016-01-16 02:14:35.000000000 +0000 @@ -11,12 +11,10 @@ libblitz0-dev (>= 0.8) | libblitz-dev, libnifti-dev, libvtk5-dev, - libdcmtk-dev | libdcmtk2-dev | libdcmtk1-dev, - libdcmtk2, + libdcmtk-dev, libpng-dev | libpng12-dev, libqt4-dev, libqwt5-qt4-dev, - dcmtk, libatlas-base-dev Standards-Version: 3.9.5 Homepage: http://od1n.sourceforge.net diff -Nru odin-1.8.8/debian/rules odin-1.8.8/debian/rules --- odin-1.8.8/debian/rules 2015-12-06 19:03:34.000000000 +0000 +++ odin-1.8.8/debian/rules 2016-01-16 02:49:02.000000000 +0000 @@ -30,7 +30,7 @@ # there is also a 'test' target that doesn't do the right thing override_dh_auto_test: - DCMDICTPATH=/usr/share/libdcmtk2/dicom.dic $(MAKE) check + $(MAKE) check # shared libs in odin package a only for private use override_dh_makeshlibs:
signature.asc
Description: PGP signature
