Hi,

just a quick report on my progress...

2015-12-17 18:18 GMT+01:00 Mattia Rizzolo <mat...@debian.org>:

>
> Ok, first, a question: do you do your debian packaging in git?
>

I'm cloning form a git repository, then clean up everything which is git
related. Why do you ask? Is there a problem with that?


And, here is a review:
>
> * trailing whitespace on the changelog line.
>

FIXED


> * maybe you're happy to discover tools like `wrap-and-sort`, to wrap the
>   Build-Depends and Depends line (and sort other stuff, and removing
>   trailing whitespaces in some other files)
>

Thank you for the hint, it's a really useful tool. ;)


> * please don't cp files that way in d/rules, I find that ugly. instead,
>   use a debian/eclipse-titan.install file.  See dh_install(1) for more
>   info.  On a related note, I prefer using $(CURDIR) instead of $$(pwd)
>   + this will also make debian/eclipse-titan.dirs useless
>   + if you need to rename files dh-exec can help you a bit, if you want
>

FIXED


> * during the compilation there are several errors like
>     ./TTCN3.hh:58:39: fatal error: RT1/TitanLoggerApiSimple.hh: No such
> file or directory
>   is this to be expected & ok?
>

It's expected and it's OK.


> * is there a way to have a more verbose build, showing all the command
>   line?
>

Added --verbose to debian/rules, I hope it'll help.


> * you told me that you could get it to build with hardening-wrapper,
>   well, to me it doesn't (see below) :)
>

Working on it, currently I don't know what is the reason of this. :/


> * can you enable parallel building? (see debhelper(7))
>

DONE


> * debian/copyright is totally inadequate.
>   + personally I won't be totally happy without a copyright following
>     copyright-format 1.0
>   + anyway, please pick a random package from the archive and try having
>     a look at what a copyright file normally looks like.
>

Will do after the hardening issue is resolved.

I move forward a little bit slow because I had a lot to do in these days
but now I can work on this almost full time, so I'll back to you soon with
all these corrections done I hope. ;)

Happy New Year
Gergely Pilisi

Reply via email to