Hi Bas!
On Sun, Jan 10, 2016 at 01:04:36PM +0100, Bas Couwenberg wrote:
> The attached debdiff updates the libquazip build dependency, and adds a
> patch to handle both the old and new libquazip name on Debian/Ubuntu.
Thanks for the patch and for the heads-up!
> diff -Nru cen64-qt-20150915-alpha/debian/changelog
> cen64-qt-20150915-alpha/debian/changelog
> --- cen64-qt-20150915-alpha/debian/changelog 2015-10-28 14:29:56.000000000
> +0100
> +++ cen64-qt-20150915-alpha/debian/changelog 2016-01-10 12:38:36.000000000
> +0100
> @@ -1,3 +1,10 @@
> +cen64-qt (20150915-alpha-1.1) UNRELEASED; urgency=medium
> +
> + * Non-maintainer upload.
> + * Update libquazip build dependency to libquazip5-dev.
You added a new patch under debian/patches/ but did not mention this
in your changelog. Changelog entries should always mention all changes
to the package source so reviewers can quickly see what was changed.
> +--- a/cen64-qt.pro
> ++++ b/cen64-qt.pro
> +@@ -63,7 +63,11 @@ win32|macx|linux_quazip_static {
> + } else {
> + # Debian distributions use a different library name for Qt5 quazip
> + system("uname -a | grep -E 'Debian|Ubuntu' > /dev/null") {
> +- LIBS += -lquazip-qt5
> ++ system("dpkg -l | grep libquazip5-dev | grep ^ii > /dev/null") {
> ++ LIBS += -lquazip5
> ++ } else {
> ++ LIBS += -lquazip-qt5
Do we actually still need to support the old package naming scheme? If
both Debian and Ubuntu are now using the new naming scheme, we most
likely don't need to support the old scheme. Might be useful for ports
though.
I'll have a look in any case and will adopt your changes.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaub...@debian.org
`. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
