Package: libgroove Version: 4.3.0-1 Severity: important Tags: patch User: pkg-multimedia-maintain...@lists.alioth.debian.org Usertags: ffmpeg2.9
Dear Maintainer, your package fails to build with the upcoming version of ffmpeg, which is planned to be released this month (and will be called 2.9 or 3.0). This bug will become release-critical at some point when this ffmpeg transition gets closer. Attached is a patch removing the use of -Werror, which is a good practice for development builds, but just causes unnecessary build failures for release builds. Please apply this patch soon. Best regards, Andreas
diff --git a/debian/patches/no-Werror.patch b/debian/patches/no-Werror.patch new file mode 100644 index 0000000..323b2b1 --- /dev/null +++ b/debian/patches/no-Werror.patch @@ -0,0 +1,19 @@ +Description: remove Werror + It is harmful in distributions as it causes unnecessary build failures. + +Author: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> +Last-Update: <2015-01-09> + +--- libgroove-4.3.0.orig/CMakeLists.txt ++++ libgroove-4.3.0/CMakeLists.txt +@@ -136,8 +136,8 @@ configure_file ( + "${PROJECT_BINARY_DIR}/config.h" + ) + +-set(LIB_CFLAGS "${C99_C_FLAGS} -pedantic -Werror -Wall -Werror=strict-prototypes -Werror=old-style-definition -Werror=missing-prototypes -D_REENTRANT -D_POSIX_C_SOURCE=200809L") +-set(EXAMPLE_CFLAGS "${C99_C_FLAGS} -pedantic -Werror -Wall -g") ++set(LIB_CFLAGS "${C99_C_FLAGS} -pedantic -Wall -Werror=strict-prototypes -Werror=old-style-definition -Werror=missing-prototypes -D_REENTRANT -D_POSIX_C_SOURCE=200809L") ++set(EXAMPLE_CFLAGS "${C99_C_FLAGS} -pedantic -Wall -g") + set(EXAMPLE_INCLUDES "${PROJECT_SOURCE_DIR}") + + add_library(groove SHARED ${LIBGROOVE_SOURCES} ${LIBGROOVE_HEADERS}) diff --git a/debian/patches/series b/debian/patches/series index 815548a..18ec44d 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1 +1,2 @@ gnu-install-dirs.patch +no-Werror.patch