Source: pacparser
Version: 1.3.6-1
Severity: important
Tags: patch
Currently pacparser only builds support for the default python3 version. As a
result, once the default version switches from python3 3.4 to 3.5, python3-
pacparser will be unusable until it can be rebuilt. The best practice (as
described in the Debian Python policy) is to build for all supported versions.
Then whichever is default, the package still works.
Additionally, while I was looking at the package, I noticed that the python
build directory isn't removed in clean and that the python and python3
package descriptions were identical. I took care of those while I was at it.
Please see the attached patch (formatted as an NMU because that's what
devscripts handed me, but I have no near term plans to NMU).
diff -Nru pacparser-1.3.6/debian/changelog pacparser-1.3.6/debian/changelog
--- pacparser-1.3.6/debian/changelog 2015-09-04 20:06:41.000000000 +0000
+++ pacparser-1.3.6/debian/changelog 2015-12-30 21:34:12.000000000 +0000
@@ -1,3 +1,14 @@
+pacparser (1.3.6-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Loop over supported python3 versions in build/install rules to add support
+ for multiple python3 versions
+ * Add removal of python build directory to clean rule
+ * Slightly change python3-pacparser descriptions to distinguish from python-
+ pacparser
+
+ -- Scott Kitterman <sc...@kitterman.com> Wed, 30 Dec 2015 21:26:03 +0000
+
pacparser (1.3.6-1) unstable; urgency=medium
* Sync to upstream version 1.3.6.
diff -Nru pacparser-1.3.6/debian/control pacparser-1.3.6/debian/control
--- pacparser-1.3.6/debian/control 2015-09-04 20:06:41.000000000 +0000
+++ pacparser-1.3.6/debian/control 2015-12-30 21:29:59.000000000 +0000
@@ -3,7 +3,7 @@
Priority: extra
Maintainer: Manu Garg <manug...@gmail.com>
Uploaders: Andrew Pollock <apoll...@debian.org>
-Build-Depends: debhelper (>= 5), python-dev, python3-dev, dh-python
+Build-Depends: debhelper (>= 5), python-dev, python3-all-dev, dh-python
Standards-Version: 3.9.6
Package: libpacparser1
@@ -76,7 +76,7 @@
Section: python
Depends: ${python3:Depends}, ${shlibs:Depends}, ${misc:Depends}
Architecture: any
-Description: Python module to parse proxy auto-config files
+Description: Python 3 module to parse proxy auto-config files
a library to parse proxy auto-config (PAC) files. Proxy auto-config files are
a vastly used proxy configuration method these days. Web browsers can use a PAC
file to determine which proxy server to use or whether to go direct for a given
@@ -91,4 +91,4 @@
behind pacparser is to make it easy to add this PAC file parsing capability to
any program (C and Python supported right now).
.
- This package contains the Python bindings for the shared library
+ This package contains the Python 3 bindings for the shared library
diff -Nru pacparser-1.3.6/debian/rules pacparser-1.3.6/debian/rules
--- pacparser-1.3.6/debian/rules 2015-09-04 20:06:41.000000000 +0000
+++ pacparser-1.3.6/debian/rules 2015-12-30 21:31:15.000000000 +0000
@@ -13,6 +13,8 @@
CFLAGS += -O2
endif
+build3vers := $(shell py3versions -sv)
+
# Build
build: build-arch build-indep
build-arch: build-stamp
@@ -20,13 +22,16 @@
build-stamp:
NO_INTERNET=yes $(MAKE) -C src
NO_INTERNET=yes $(MAKE) -C src pymod
- NO_INTERNET=yes $(MAKE) -C src pymod PYTHON=python3
+ set -e && for i in $(build3vers); do \
+ NO_INTERNET=yes $(MAKE) -C src pymod PYTHON=python$$i; \
+ done
touch $@
clean:
dh_testdir
dh_testroot
rm -f build-stamp
+ rm -rf src/pymod/build/
$(MAKE) -C src clean
dh_clean
@@ -39,7 +44,9 @@
# Install to debian/tmp
NO_INTERNET=yes $(MAKE) -C src DESTDIR=$(CURDIR)/debian/tmp install
NO_INTERNET=yes $(MAKE) -C src DESTDIR=$(CURDIR)/debian/tmp install-pymod EXTRA_ARGS=--install-layout=deb
- NO_INTERNET=yes $(MAKE) -C src DESTDIR=$(CURDIR)/debian/tmp install-pymod EXTRA_ARGS=--install-layout=deb PYTHON=python3
+ set -e && for i in $(build3vers); do \
+ NO_INTERNET=yes $(MAKE) -C src DESTDIR=$(CURDIR)/debian/tmp install-pymod EXTRA_ARGS=--install-layout=deb PYTHON=python$$i; \
+ done
dh_install -s --autodest
dh_python2 -s
