Control: tag -1 + patch moreinfo Hi,
On Thu, 30 May 2013 22:49:23 +0200 Kurt Roeckx <k...@roeckx.be> wrote:
> Package: sbuild
> Version: 0.64.0-1+buildd20130522.0
> Severity: important
what justifies Severity: important?
> I got this in my log file:
> Purging /A«BUILDDIRA»
> Not cleaning session: cloned chroot in use
> E: Disc space is probably not sufficient for building.
> I: Source needs 2703644 KiB, while 4089748 KiB is free.)
>
> And then it marked the package as failed. It shouldn't have
> failed that package. At worst it should have been marked as
> attempted.
Is sbuild still marking packages as failed in this case? The code in the
function status_trigger() in bin/sbuild instead suggests that insufficient
space is resulting in the status 'given-back'.
If you nevertheless want it to be set to 'attempted' instead, the fix is very
simple:
diff --git a/bin/sbuild b/bin/sbuild
index ff5fc71..61a2fc5 100755
--- a/bin/sbuild
+++ b/bin/sbuild
@@ -320,13 +320,13 @@ sub status_trigger ($$) {
if ($status eq "failed" &&
isin($build->get('Pkg Fail Stage'),
qw(fetch-src install-core install-essential install-deps
- unpack check-unpacked-version check-space hack-binNMU
+ unpack check-unpacked-version hack-binNMU
install-deps-env apt-get-clean apt-get-update
apt-get-upgrade apt-get-distupgrade))) {
$build->set_status('given-back');
} elsif ($status eq "failed" &&
isin ($build->get('Pkg Fail Stage'),
- qw(build arch-check))) {
+ qw(build arch-check check-space))) {
$build->set_status('attempted');
}
}
Though I'd like to know your rationale before changing this including the
effects of this change and how this was handled so far.
Thanks!
cheers, josch
signature.asc
Description: signature
