Package: gummi
Version: 0.6.5-6
Severity: normal
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu xenial ubuntu-patch

Dear Maintainer,

In Ubuntu, I've noticed that gummi tries to ship locale files in
the /usr/@DATADIRNAME@ directory, litterally.

Now, I haven't done much background investigation on this, and I suspect
it is failing in Ubuntu and not currently happening in Debian because of a
difference in the toolchain package versions.

What happens precisely is that rather than correctly replacing @DATADIRNAME@
with 'share', the value is kept unreplaced. It should be sufficient to replace
uses of $(prefix)/$(DATADIRNAME) with $(datadir).

In any case, I'm including a patch for your convenience, since I expect some
time in the future gummi may catch the same issue in Debian.

If such an occurence does happen, you'll notice lintian warnings too:
W: gummi: non-standard-dir-in-usr usr/@DATADIRNAME@/
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/ar/LC_MESSAGES/gummi.mo
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/ca/LC_MESSAGES/gummi.mo
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/cs/LC_MESSAGES/gummi.mo
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/da/LC_MESSAGES/gummi.mo
W: gummi: file-in-unusual-dir usr/@DATADIRNAME@/locale/de/LC_MESSAGES/gummi.mo
[...]

*** /tmp/tmpcMIZb0/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/upgrade_datadir.patch: replace outdated uses of
    $(DATADIRNAME) with $(datadir).


Thanks for considering the patch.


-- System Information:
Debian Release: stretch/sid
  APT prefers xenial-updates
  APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 
'xenial'), (100, 'xenial-backports'), (99, 'xenial-proposed')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-19-generic (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru gummi-0.6.5/debian/patches/series gummi-0.6.5/debian/patches/series
--- gummi-0.6.5/debian/patches/series	2015-11-28 19:09:50.000000000 -0500
+++ gummi-0.6.5/debian/patches/series	2015-12-22 19:59:50.000000000 -0500
@@ -3,3 +3,4 @@
 libgthread-2.0_link.patch
 use-system-synctex.patch
 no-predictable-tmpfiles.patch
+upgrade_datadir.patch
diff -Nru gummi-0.6.5/debian/patches/upgrade_datadir.patch gummi-0.6.5/debian/patches/upgrade_datadir.patch
--- gummi-0.6.5/debian/patches/upgrade_datadir.patch	1969-12-31 19:00:00.000000000 -0500
+++ gummi-0.6.5/debian/patches/upgrade_datadir.patch	2015-12-22 20:26:26.000000000 -0500
@@ -0,0 +1,20 @@
+From: Mathieu Trudel-Lapierre <mathieu...@ubuntu.com>
+Subject: Replace outdated prefix/DATADIRNAME with just datadir.
+---
+ po/Makefile.in.in |    3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+Index: b/po/Makefile.in.in
+===================================================================
+--- a/po/Makefile.in.in
++++ b/po/Makefile.in.in
+@@ -33,8 +33,7 @@ exec_prefix = @exec_prefix@
+ datadir = @datadir@
+ datarootdir = @datarootdir@
+ libdir = @libdir@
+-DATADIRNAME = @DATADIRNAME@
+-itlocaledir = $(prefix)/$(DATADIRNAME)/locale
++itlocaledir = $(datadir)/locale
+ subdir = po
+ install_sh = @install_sh@
+ # Automake >= 1.8 provides @mkdir_p@.

Reply via email to