On Tue, 27 Oct 2015 13:37:46 +0000 Dominic Cleal <dcl...@redhat.com> wrote: > On 22/10/15 11:52, Erebus wrote: > > Package: augeas-lenses > > Version: 1.2.0-0.2 > > Severity: serious > > Justification: httpd lens is broken in 1.2 > > > > Dear Maintainer, > > > > I have learned that augeas-lenses v1.2 includes a broken httpd lens. In > > particular, the 1.2 lens throws errors when an httpd config happens to end > > with > > a comment. This is causing trouble for several other projects. > > > > This issue is fixed in upstream version 1.4. > > > > See also: https://github.com/letsencrypt/letsencrypt/issues/981 > > Attached is a patch against upstream's Augeas 1.2.0 tarball to resolve > the issue reported on the letsencrypt issue when parsing ssl.conf.
I'm wondering if the severity of that bug could not be reduced. Indeed, I wasn't successful trying to reproduce the bug mentioned in the above link concerning ssl.conf. https://github.com/letsencrypt/letsencrypt/issues/981#issuecomment-148525136 suggests version 1.2 isn't affected by this bug. However the attached patch fixes some other bugs with 1.2 httpd lens which I was able to reproduce. Dominic, Erebus, before lowering the severity of this bug, could you confirm or infirm that the bug with the sample ssl.conf isn't present in Augeas 1.2? And do you confirm that the httpd lens in Augeas 1.2 isn't broken any more once the attached patch is applied? Cheers
