On Wed, 25 Nov 2015 10:06:37 +0530 Sunil Mohan Adapa <su...@medhas.org> wrote: > > Looks good to me. Have you tested this? If yes, please go ahead and > commit the patch. > > It looks like we might face issues with /etc/network/interfaces not > being cleared out by freedombox-setup. This patch can go in even with > that issue. > > -- > Sunil >
I've committed this patch. I tested it with Stretch Alpha 4 installer in Virtualbox. After install, I found that /etc/network/interfaces was empty except for the loopback device. But there's a different issue: the installer created a network manager connection "Wired Connection 1". I tried testing with 2 network configurations: - Bridged Adapter: Wired Connection 1 is active, FreedomBox WAN is not active. Plinth cannot be accessed from host machine. - Bridged Adapter + Host-only Adapter: FreedomBox WAN is active on enp0s3, Wired Connection 1 is active on enp0s8, FreedomBox LAN enp0s8 is not active. Plinth can be access on bridged adapter IP only. So it looks like we will need to check for this connection and delete it. Some more ideas for further improvements: - There are still several prompts in the install process, maybe these can be automated. - This preseed file appears to be only meant for x86 or amd64. Since Debian has installers for several armhf boards now, we can look into making a preseed file that works on armhf. -- James
signature.asc
Description: OpenPGP digital signature