Control: owner -1 ! Control: tags -1 moreinfo Hi
check-all-the-things: codespell --quiet-level=3 cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open any of the paths given.' [src/bitz/manager.cpp:212]: (error) Exception thrown in throw() function. duck E: debian/control: Vcs-Browser: http://anonscm.debian.org/cgit/collab-maint/bitzserver.git: ERROR (Certainty:certain) Curl:0 HTTP:404 No error pep8 --ignore W191 . pyflakes3 . ./test/icap-client.py:17:27: invalid syntax print "----- OPTIONS -----" ^ ./modules/modpy/modules/modpy.py:9:22: invalid syntax print "init() called"; ^ and now the review: 1) priority maybe optional? https://www.debian.org/doc/debian-policy/ch-archive.html#s-priorities 2) bitz-server.install usr/share/man/man* <-- they belong to dh_installman 3) I would avoid to play with systemd scripts because of systemd bugs (I think they are in dh-systemd the problems, right?) 4) libcap0.install, please do not install .la files (they should be forbidden in debian IIRC and useless) 5) symbols: pease use c++filt sed 's/ \(_.*\) \(.*\)/ (c++)"\1" \2/' old | c++filt > new.symbols the other stuff looks good to me (nitpick: the GPL3 license has incorrect FSF address) cheers, G.
